Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http-service: k8s deploy support #5323

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

csuzhangxc
Copy link
Member

What problem does this PR solve?

support to deploy the http-serivce for Kubernetes

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from csuzhangxc. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/M label Oct 10, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #5323 (d95bd7b) into master (a713860) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5323   +/-   ##
=======================================
  Coverage   57.65%   57.65%           
=======================================
  Files         252      252           
  Lines       30810    30810           
=======================================
  Hits        17763    17763           
  Misses      11303    11303           
  Partials     1744     1744           
Flag Coverage Δ
unittest 57.65% <ø> (ø)

@csuzhangxc csuzhangxc merged commit 45cd55c into pingcap:master Oct 11, 2023
4 of 6 checks passed
@csuzhangxc csuzhangxc deleted the http-k8s branch October 11, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants