-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: fix redundant pvc and pv in metadata #5461
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5461 +/- ##
=========================================
Coverage ? 61.57%
=========================================
Files ? 230
Lines ? 29176
Branches ? 0
=========================================
Hits ? 17965
Misses ? 9436
Partials ? 1775
|
/retest |
/run-pull-e2e-kind-br |
1 similar comment
/run-pull-e2e-kind-br |
/run-pull-e2e-kind-br |
2 similar comments
/run-pull-e2e-kind-br |
/run-pull-e2e-kind-br |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/cherry-pick release-1.5 |
@csuzhangxc: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Fix the bug that if there are redundant pvc or pv of backup tidb cluster, the backup can succeed but the restore can fail.
The redundant pvc or pv means:
Closes #5459
What is changed and how does it work?
At first we retrieve all the pvcs and pvs that may belong to the backup tidb cluster. Then we filter pvc by the tikv pod and filter pv by the pvc.
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.