Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy: add tiproxy on aws/aliyun tf example #5474

Merged
merged 3 commits into from Dec 21, 2023
Merged

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Dec 19, 2023

What problem does this PR solve?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Signed-off-by: xhe <xw897002528@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign shuijing198799 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/L label Dec 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6724387) 61.58% compared to head (5582d34) 61.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5474      +/-   ##
==========================================
- Coverage   61.58%   61.57%   -0.02%     
==========================================
  Files         230      230              
  Lines       29179    29179              
==========================================
- Hits        17971    17966       -5     
- Misses       9434     9437       +3     
- Partials     1774     1776       +2     
Flag Coverage Δ
unittest 61.57% <ø> (-0.02%) ⬇️

deploy/aws/variables.tf Outdated Show resolved Hide resolved
xhebox and others added 2 commits December 21, 2023 14:19
Signed-off-by: xhe <xw897002528@gmail.com>
@csuzhangxc csuzhangxc merged commit be648db into pingcap:master Dec 21, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants