Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiproxy: fix http tls when only tls cluster is enabled #5555

Merged
merged 1 commit into from Feb 26, 2024

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Feb 25, 2024

What problem does this PR solve?

Before, tiproxy will use TLS certs from TiDB to serve both SQL and HTTP ports. When only tlsCluster is enabled, there will be errors(others will try to use HTTPS to access tiproxy).

Since now we have dedicated server-http-tls options, we can now specify certs for tiproxy when only tlsCluster is enabled.

For backward compatibility, it is also enabled on only tlsTiDB, which is wrong. But it is kept for now.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot added the size/S label Feb 25, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 61.29%. Comparing base (521a829) to head (0f21834).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5555      +/-   ##
==========================================
- Coverage   61.32%   61.29%   -0.03%     
==========================================
  Files         235      235              
  Lines       30080    30083       +3     
==========================================
- Hits        18446    18440       -6     
- Misses       9792     9798       +6     
- Partials     1842     1845       +3     
Flag Coverage Δ
unittest 61.29% <0.00%> (-0.03%) ⬇️

Copy link
Contributor

ti-chi-bot bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-26 01:53:04.013343854 +0000 UTC m=+840472.760966967: ☑️ agreed by csuzhangxc.

@ti-chi-bot ti-chi-bot bot added the approved label Feb 26, 2024
@csuzhangxc csuzhangxc merged commit a002cb1 into pingcap:master Feb 26, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants