Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ebs br: add gc immune flag #5567

Merged
merged 3 commits into from Mar 12, 2024
Merged

ebs br: add gc immune flag #5567

merged 3 commits into from Mar 12, 2024

Conversation

BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Mar 6, 2024 •
edited

What problem does this PR solve?

What is changed and how does it work?

Code changes

Provide an new flag attribute skipGC to VolumeBackup CRD at top level. By setting it manually, customer can make the volumebackup immune to GC triggered by backup scheduler.

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

@ti-chi-bot ti-chi-bot bot requested a review from howardlau1999 March 6, 2024 09:26
@ti-chi-bot ti-chi-bot bot added the size/L label Mar 6, 2024
@BornChanger
Copy link
Contributor Author

/cc @WangLe1321 @YuJuncen

@ti-chi-bot ti-chi-bot bot requested review from WangLe1321 and YuJuncen March 6, 2024 09:30
@BornChanger
Copy link
Contributor Author

/retest

@BornChanger
br: support gc immune backup specification
18c8197 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@ti-chi-bot ti-chi-bot bot added size/M and removed size/L labels Mar 6, 2024
@BornChanger
Copy link
Contributor Author

/retest

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024 •
edited

Codecov Report

Attention: Patch coverage is 22.22222% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 67.30%. Comparing base (f7c4a71) to head (906fd91).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5567      +/-   ##
==========================================
+ Coverage   61.43%   67.30%   +5.86%     
==========================================
  Files         235      246      +11     
  Lines       30206    34097    +3891     
==========================================
+ Hits        18558    22949    +4391     
+ Misses       9785     9227     -558     
- Partials     1863     1921      +58
Flag Coverage Δ
e2e 45.88% <0.00%> (?)
unittest 61.42% <22.22%> (-0.02%) ⬇️

@BornChanger
*: rename attribute name
3c9bbeb 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot removed the lgtm label Mar 8, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-08 09:14:56.744795073 +0000 UTC m=+417723.767041461: ☑️ agreed by WangLe1321.
  • 2024-03-08 09:18:51.393252346 +0000 UTC m=+417958.415498731: ✖️🔁 reset by ti-chi-bot[bot].

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 8, 2024

New changes are detected. LGTM label has been removed.

@BornChanger
Copy link
Contributor Author

/retest

@BornChanger
Copy link
Contributor Author

/run-pull-e2e-kind-across-kubernetes

@BornChanger
Copy link
Contributor Author

/run-pull-e2e-kind-br

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 12, 2024

@YuJuncen: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WangLe1321, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csuzhangxc csuzhangxc merged commit 517a47e into pingcap:master Mar 12, 2024
9 of 13 checks passed
@csuzhangxc
Copy link
Member

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.5: #5571.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 12, 2024
Merged
10 tasks
csuzhangxc pushed a commit that referenced this pull request Mar 12, 2024
@ti-chi-bot @BornChanger
ebs br: add gc immune flag (#5567) (#5571)
249611f 
Signed-off-by: BornChanger <dawn_catcher@126.com>
Co-authored-by: BornChanger <dawn_catcher@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkg- nkg- nkg- left review comments

@WangLe1321 WangLe1321 WangLe1321 approved these changes

@YuJuncen YuJuncen YuJuncen approved these changes

@howardlau1999 howardlau1999 Awaiting requested review from howardlau1999

Assignees
No one assigned
Labels
approved area/ebs-br size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@BornChanger @codecov-commenter @csuzhangxc @ti-chi-bot @nkg- @WangLe1321 @YuJuncen