Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BR] add pv name in restore EBS vol #5612

Merged
merged 2 commits into from Apr 15, 2024

Conversation

wxiaomou
Copy link
Contributor

What problem does this PR solve?

What is changed and how does it work?

""kubernetes.io/created-for/pv/name" tag is a common ebs tag added by CSI driver, current restore EBS vol does not have it
. Added in this PR.
https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/pkg/driver/controller_test.go#L1551

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 12, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 12, 2024
@BornChanger
Copy link
Contributor

/retest

@BornChanger
Copy link
Contributor

/cherry-pick-for-release-1.5

@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 46.25%. Comparing base (72bccb5) to head (f9cfa89).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5612       +/-   ##
===========================================
- Coverage   61.49%   46.25%   -15.24%     
===========================================
  Files         235      219       -16     
  Lines       30337    30197      -140     
===========================================
- Hits        18655    13969     -4686     
- Misses       9813    14555     +4742     
+ Partials     1869     1673      -196     
Flag Coverage Δ
e2e 46.25% <0.00%> (?)
unittest ?

@wxiaomou
Copy link
Contributor Author

/retest

Copy link
Contributor

ti-chi-bot bot commented Apr 12, 2024

@wxiaomou: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot removed the lgtm label Apr 15, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-12 03:39:22.521148715 +0000 UTC m=+1192824.048689264: ☑️ agreed by BornChanger.
  • 2024-04-15 08:28:37.916633878 +0000 UTC m=+240337.027680326: ✖️🔁 reset by ti-chi-bot[bot].

Copy link
Contributor

ti-chi-bot bot commented Apr 15, 2024

New changes are detected. LGTM label has been removed.

@csuzhangxc csuzhangxc merged commit c2dbdc2 into pingcap:master Apr 15, 2024
5 of 6 checks passed
@csuzhangxc
Copy link
Member

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.5: #5615.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants