retry evict leader when upgrading TiKV if needed (#5613) #5616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #5613
What problem does this PR solve?
close #5614
In some cases when upgrading TiKV, the evict-leader-scheduler may not be added or missing in PD, but the
evictLeaderBeginTime
annotation of the TiKV pod is added. As TiDB Operator will not call PD API to add evict-leader-scheduler again, then the upgrade operation is blocked.In this PR, we check whether the evict-leader-scheduler exists if a timeout (10m) is reached, and try to add evict-leader-again if it's missing.
What is changed and how does it work?
Code changes
Tests
controller.GetPDClient(u.deps.PDControl, tc).BeginEvictLeader(storeID)
call inbeginEvictLeader
wait for evictition to complete
), and check theevictLeaderBeginTime
annotation existingevictLeaderBeginTime
is updated to the new timeSide effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.