Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix scheduled backup to ceph object storage #576

Merged
merged 15 commits into from Jun 18, 2019
Merged

fix scheduled backup to ceph object storage #576

merged 15 commits into from Jun 18, 2019

Conversation

LinuxGit
Copy link
Contributor

@LinuxGit LinuxGit commented Jun 12, 2019 •
edited

What problem does this PR solve?

  • add additional labels for backup/restore job's pod, e.g.(TEP) store tidb cluster's insanceI
    D and backup time in restore job's pod labels.
  • support set successfulJobsHistoryLimit and failedJobsHistoryLimit
  • fix scheduled backup to ceph object storage, add AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY env
  • fix restore job downloader destDir
  • add waiting for tidb up logic in restore job's script(as PM' requirement, we need to create restore tidb cluster and create restore job at the same time in TEP)
  • adjust backupName, we need to use it in restore job, like name and labels, and it has length and lower case limit
  • disable backup mysql database by default

What is changed and how it works?

Check List

Tests

  • E2E test
  • Stability test

Code changes

  • Has Helm charts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

fix scheduled backup to ceph object storage

@LinuxGit LinuxGit mentioned this pull request Jun 12, 2019
Closed
@LinuxGit LinuxGit changed the title [DNM]fix schedule backup to ceph fix scheduled backup to ceph object storage Jun 14, 2019
@LinuxGit
Copy link
Contributor Author

@gregwebs Help check if the changes are in conflict with DBasS. Thanks. Suggestions are welcome.

@LinuxGit LinuxGit requested a review from gregwebs June 14, 2019 21:41
weekface
weekface previously approved these changes Jun 17, 2019
View reviewed changes
@LinuxGit
Copy link
Contributor Author

/run-e2e-tests

@LinuxGit
Copy link
Contributor Author

/run-e2e-tests

@xiaojingchen
Copy link
Contributor

@LinuxGit please resolves the conflicts

@LinuxGit
Copy link
Contributor Author

/run-e2e-tests

weekface
weekface approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaojingchen xiaojingchen merged commit f3624b5 into pingcap:master Jun 18, 2019
@LinuxGit LinuxGit deleted the Louis/ceph-backup-restore branch June 18, 2019 11:59
@LinuxGit LinuxGit mentioned this pull request Jul 2, 2019
Closed
@weekface weekface mentioned this pull request Jul 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tennix tennix tennix left review comments

@weekface weekface weekface approved these changes

@xiaojingchen xiaojingchen xiaojingchen approved these changes

@cofyc cofyc Awaiting requested review from cofyc

@gregwebs gregwebs Awaiting requested review from gregwebs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@LinuxGit @xiaojingchen @gregwebs @weekface @tennix