TiKV failover #77
Merged
TiKV failover #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
/run-e2e-tests |
xiaojingchen
previously approved these changes
Sep 7, 2018
|
/run-e2e-tests |
tennix
reviewed
Sep 7, 2018
| TombStoneStores map[string]TiKVStore `json:"tombStoneStores,omitempty"` | ||
| Phase MemberPhase `json:"phase,omitempty"` | ||
| StatefulSet *apps.StatefulSetStatus `json:"statefulSet,omitempty"` | ||
| Stores map[string]TiKVStore `json:"stores,omitempty"` |
There was a problem hiding this comment.
Will Stores contain failure stores or tombstone stores?
There was a problem hiding this comment.
Stores contain failure stores, but don't contain tombstone stores.
pkg/manager/member/tikv_failover.go
Outdated
| tc.Status.TiKV.FailureStores = nil | ||
| } | ||
|
|
||
| func allTiKVStoressAreReady(tc *v1alpha1.TidbCluster) bool { |
There was a problem hiding this comment.
s/allTiKVStoress/AreReady/allTiKVStoresAreReady/
| if tc.Status.TiKV.FailureStores != nil { | ||
| tkmm.tikvFailover.Recover(tc) | ||
| } | ||
| } else if int(tc.Spec.TiKV.Replicas) == int(tc.Status.TiKV.StatefulSet.Replicas) { |
|
|
||
| "time" | ||
|
|
||
| . "github.com/onsi/gomega" |
There was a problem hiding this comment.
Add revive instruction for dot-import.
You can choose whatever you like to follow revive linter suggests.
retool do revive -formatter friendly -config revive.toml pkg/...
|
|
||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
|
|
||
| "time" |
There was a problem hiding this comment.
Could you separate the standard library and external library?
| pdClient.AddReaction(controller.GetConfigActionType, func(action *controller.Action) (interface{}, error) { | ||
| if test.getCfgErr { | ||
| return nil, fmt.Errorf("get config failed") | ||
| } else { |
|
/run-e2e-tests |
xiaojingchen
approved these changes
Sep 8, 2018
queenliuxx
pushed a commit
to queenliuxx/tidb-operator
that referenced
this pull request
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #58, adds TiKV failover feature to TiDB Operator.
@tennix @onlymellb @xiaojingchen @gregwebs PTAL