Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tkctl log output exception (#797) #799

Merged
merged 1 commit into from Aug 22, 2019
Merged

fix tkctl log output exception (#797) #799

merged 1 commit into from Aug 22, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Aug 21, 2019

cherry-pick #797 to release-1.0

What problem does this PR solve?

fix #796

What is changed and how does it work?

Check List

Tests

  • Manual test

Code changes

  • Has Go code change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

fix tkctl log output exception

@sre-bot sre-bot mentioned this pull request Aug 21, 2019
Merged
@sre-bot sre-bot requested review from aylei and weekface August 21, 2019 13:18
aylei
aylei approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@onlymellb onlymellb merged commit 2fbf805 into pingcap:release-1.0 Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aylei aylei aylei approved these changes

@weekface weekface Awaiting requested review from weekface

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sre-bot @aylei @onlymellb