session: fix show variable result of tidb_enable_window_function after upgrade
#13866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13866 +/- ##
================================================
+ Coverage 80.3896% 80.4014% +0.0118%
================================================
Files 475 474 -1
Lines 119223 118509 -714
================================================
- Hits 95843 95283 -560
+ Misses 15870 15803 -67
+ Partials 7510 7423 -87 |
jackysp
added
the
status/can-merge
|
/run-all-tests |
|
@lysu merge failed. |
|
/merge |
|
/run-all-tests |
lysu
added
status/LGT2
|
cherry pick to release-3.0 failed |
|
/run-cherry-picker |
|
/run-cherry-picker |
|
cherry pick to release-3.0 in PR #14131 |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
What problem does this PR solve?
tidb_enable_window_functionwill display as1inshow variables's result after upgrade from old version, but realtidb_enable_window_functionvalue will keep 0 due to keep syntax compatibility， on another hand, new cluster can safe use1as default value.What is changed and how it works?
when upgrade from old version, insert a default 0 value if no exists record in
GLOBAL_VARIABLESCheck List
Tests
Code changes
Side effects
Related changes
Release note
show variableresult oftidb_enable_window_functionafter upgradeThis change is