Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define temporary storage in config file. #13982

Closed
SunRunAway opened this issue Dec 9, 2019 · 0 comments · Fixed by #14600
Closed

Define temporary storage in config file. #13982

SunRunAway opened this issue Dec 9, 2019 · 0 comments · Fixed by #14600
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/execution SIG execution type/enhancement

Comments

@SunRunAway
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?
    If possible, provide a recipe for reproducing the error.

In #11607, the temporary storage is stored in OS's temporary directory which is defined by environment viriable TMPDIR.
See

tidb/util/chunk/disk.go

Line 47 in 0e0faee

var tmpDir = filepath.Join(os.TempDir(), "tidb-server-"+filepath.Base(os.Args[0]))
,

  1. What did you expect to see?

We should define the location of temporary storage in config file.

  1. What did you see instead?

  2. What version of TiDB are you using (tidb-server -V or run select tidb_version(); on TiDB)?

4.0.0-alpha
@SunRunAway SunRunAway added type/enhancement help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. sig/execution SIG execution labels Dec 9, 2019
@SunRunAway SunRunAway mentioned this issue Dec 9, 2019
Open
14 tasks
@hsqlu hsqlu mentioned this issue Feb 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/execution SIG execution type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config: define temporary storage in config file. hsqlu/tidb
1 participant
@SunRunAway