Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call For Participation: Improve the JSON functionality #14486

Open
22 of 24 tasks
qw4990 opened this issue Jan 15, 2020 · 5 comments
Open
22 of 24 tasks

Call For Participation: Improve the JSON functionality #14486

qw4990 opened this issue Jan 15, 2020 · 5 comments
Labels
component/json good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement

Comments

@qw4990
Copy link
Contributor

qw4990 commented Jan 15, 2020

All issues are open and welcomed to contributors. You can join #sig-exec on tidb community slack to discuss and get help from someone.

Feature Request

Is your feature request related to a problem? Please describe:

Here we collect some issues about JSON functions, please help us to fix them if you are interested in any of them:

  • Implement the unsupported JSON function JSON_MERGE_PATCH; difficulty: medium
  • Implement the unsupported JSON function JSON_PRETTY; difficulty: medium
  • 7623 Implement the unsupported JSON function JSON_ARRAYAGG; difficulty: medium executor: add builtin aggregate function json_arrayagg #19957
  • 7623 Implement the unsupported JSON function JSON_OBJECTAGG; difficulty: medium; @hg2990656 *: add builtin aggregate function json_objectagg #11154
  • 14488 Implement the unsupported JSON function JSON_STORAGE_SIZE ; difficulty: medium
  • 12178 JSON_EXTRACT gets wrong decimal when insert into table; difficulty: easy
  • 13722 Invalid JSON value for CAST to DATE/TIME/DATETIME/TIMESTAMP from column json_extract for virtual column; difficulty: easy
  • 9995 JSON_OBJECT handle long strings wrongly; difficulty: easy
  • 10460 Compare json objects wrongly; difficulty: easy
  • 10461 Compare json floats wrongly; difficulty: easy
  • 11386 Loss accuracy when inserting json records; difficulty: easy
  • 9988 Casting times to json cannot be compatible with MySQL; difficulty: easy
  • 10390 Casting strings to json cannot be compatible with MySQL; difficulty: easy
  • 12233 JSON_EXTRACT fails to cast as bool; difficulty: easy
  • 11489 Convert json to uint different from mysql; difficulty: easy
  • 10467 Incorrect GROUP BY for JSON values; difficulty: easy
  • 13710 Incorrect results when processing JSON_EXTRACT(...) IN (...); difficulty: easy

Thanks for your help! If you have any question, please discuss it with us in our slack channel #sig-exec on tidb community slack or in this issue by comments :D

Document Collection

  • Proposal doc: (follow reference implementation in MySQL)
  • Weekly report: TODO

Talent Challenge Program information

  • Mentor of this issue: @morgo
  • Recommended skills: Golang, MySQL
  • Estimated Workloads: 1 month

Milestones and action items

Milestone 1: Merge missing functions from 5.7.

  • JSON_MERGE_PATCH
  • JSON_ARRAYAGG

Milestone 2: Fix bugs in current implementation

  • JSON_OBJECT handle long strings wrongly
  • Casting times to json cannot be compatible with MySQL

Milestone 3: Implement functionality from MySQL 8.0

  • JSON_TABLE function
  • JSON_VALUE function
  • Multi-valued indexes (member of function)

* The MySQL 8.0 functionality may need to be broken down into design docs, since TiDB does not currently support TABLE functions or multi-valued indexes. There may be some assumptions that we've made that will need to be fixed for these to be added.

@qw4990 qw4990 added type/enhancement help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Jan 15, 2020
@zz-jason zz-jason changed the title Improve the JSON functionality Call For Participation: Improve the JSON functionality Jan 21, 2020
@SunRunAway SunRunAway added this to Triage in SIG Runtime Kanban via automation Mar 6, 2020
@SunRunAway SunRunAway moved this from Triage to In progress in SIG Runtime Kanban Mar 6, 2020
@ghost ghost added the component/json label Jul 25, 2020
@YiuTerran
Copy link

Please watch Multi-Valued Indexes introduced by MySQL 8.0.17, it's quite usefull.

Implementation of member of should be considered.

@xxchan
Copy link
Contributor

xxchan commented Aug 9, 2021

Hi, what's the status of this issue?

@morgo
Copy link
Contributor

morgo commented Aug 9, 2021

Hi, what's the status of this issue?

@xxchan We have someone working on the casting behavior, but nobody is yet looking at Milestone 3. These are harder tasks, if you would like to take a look at one, please reach out to me on Slack (Morgan Tocker). I would be happy to talk you through the issues.

@dveeden
Copy link
Contributor

dveeden commented Mar 26, 2024

Would be good to also add these:

  • JSON_SCHEMA_VALID()
  • JSON_SCHEMA_VALIDATION_REPORT()

@dveeden
Copy link
Contributor

dveeden commented Apr 20, 2024

  • JSON_SCHEMA

#52779

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/json good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement
Projects
No open projects
SIG Runtime Kanban
  
In Progress
Development

No branches or pull requests

5 participants