table not exist error code on release-3.0 is not the same as master

[cyliu0]

Bug Report

Please answer these questions before submitting your issue. Thanks!

On master the error code is 1146. But It's 1105 on release-3.0

1. What did you do?

mysql root@127.0.0.1:test> create table t (a int)
Query OK, 0 rows affected
Time: 0.006s
mysql root@127.0.0.1:test> create view v1 as select * from t
Query OK, 0 rows affected
Time: 0.005s
mysql root@127.0.0.1:test> create view v2 as select * from v1
Query OK, 0 rows affected
Time: 0.005s

2. What did you expect to see?

On master:

mysql root@127.0.0.1:test> create or replace view v1 as select * from v2
(1146, "Table 'test.v1' doesn't exist")
mysql root@127.0.0.1:test> select tidb_version()
+-------------------------------------------------------------------+
| tidb_version()                                                    |
+-------------------------------------------------------------------+
| Release Version: v4.0.0-beta.2-395-g1c3435b4a                     |
| Git Commit Hash: 1c3435b4a62126de95583a67c3008f143e362851         |
| Git Branch: master                                                |
| UTC Build Time: 2020-05-06 07:18:30                               |
| GoVersion: go1.14.2                                               |
| Race Enabled: false                                               |
| TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306 |
| Check Table Before Drop: false                                    |
+-------------------------------------------------------------------+
1 row in set
Time: 0.014s

3. What did you see instead?

On release-3.0:

mysql root@127.0.0.1:test> create or replace view v1 as select * from v2
(1105, "Table 'test.v1' doesn't exist")
mysql root@127.0.0.1:test> select tidb_version()
+-------------------------------------------------------------------+
| tidb_version()                                                    |
+-------------------------------------------------------------------+
| Release Version: v3.0.12-99-g62e831481                            |
| Git Commit Hash: 62e8314819dbccf4ee0db5163cab806672b07324         |
| Git Branch: HEAD                                                  |
| UTC Build Time: 2020-05-06 06:47:22                               |
| GoVersion: go version go1.14.2 darwin/amd64                       |
| Race Enabled: false                                               |
| TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306 |
| Check Table Before Drop: false                                    |
+-------------------------------------------------------------------+
1 row in set
Time: 0.015s

4. What version of TiDB are you using? (tidb-server -V or run select tidb_version(); on TiDB)

[XuHuaiyu]

We can add mysql.ErrNoSuchTable: mysql.ErrNoSuchTable, here.

[bb7133]

This is actually expected @cyliu0 :

Some error codes are not correct in 3.0, as you may see and we decided to fix them in the later(4.0+) version. However, the change didn't apply to 3.0 because we want to make the change only in major versions.