Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INFORMATION_SCHEMA.CLUSTER_HARDWARE misses the disk information for tiflash node #24038

Closed
baurine opened this issue Apr 15, 2021 · 5 comments
Closed
Labels
severity/moderate sig/diagnosis SIG: Diagnosis type/bug This issue is a bug.

Comments

@baurine
Copy link
Contributor

baurine commented Apr 15, 2021

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. Connect the TiDB database, for example: mysql -u root -h 10.0.1.12 -P 4000
  2. Run SQL: select * from INFORMATION_SCHEMA.CLUSTER_HARDWARE where TYPE='tiflash';

2. What did you expect to see? (Required)

The result rows should have 3 kinds of value for DEVICE_TYPE column: cpu, disk, memory

mysql> select * from INFORMATION_SCHEMA.CLUSTER_HARDWARE where TYPE='tiflash';
+---------+----------------+-------------+-------------------------+--------------------+-------------+
| TYPE    | INSTANCE       | DEVICE_TYPE | DEVICE_NAME             | NAME               | VALUE       |
+---------+----------------+-------------+-------------------------+--------------------+-------------+
| tiflash | 10.0.1.12:3930 | cpu         | cpu                     | cpu-logical-cores  | 2           |
| tiflash | 10.0.1.12:3930 | cpu         | cpu                     | cpu-physical-cores | 2           |
| tiflash | 10.0.1.12:3930 | cpu         | cpu                     | cpu-frequency      | 2303MHz     |
| tiflash | 10.0.1.12:3930 | cpu         | cpu                     | l1-cache-size      | 32768       |
| tiflash | 10.0.1.12:3930 | cpu         | cpu                     | l1-cache-line-size | 64          |
| tiflash | 10.0.1.12:3930 | cpu         | cpu                     | l2-cache-size      | 262144      |
| tiflash | 10.0.1.12:3930 | cpu         | cpu                     | l2-cache-line-size | 64          |
| tiflash | 10.0.1.12:3930 | cpu         | cpu                     | l3-cache-size      | 6291456     |
| tiflash | 10.0.1.12:3930 | cpu         | cpu                     | l3-cache-line-size | 64          |
| tiflash | 10.0.1.12:3930 | disk        | mapper/vagrant--vg-root | type               | SSD         |
| tiflash | 10.0.1.12:3930 | disk        | mapper/vagrant--vg-root | fstype             | ext4        |
| tiflash | 10.0.1.12:3930 | disk        | mapper/vagrant--vg-root | path               | /           |
| tiflash | 10.0.1.12:3930 | disk        | mapper/vagrant--vg-root | total              | 66355564544 |
| tiflash | 10.0.1.12:3930 | disk        | mapper/vagrant--vg-root | free               | 54576488448 |
| tiflash | 10.0.1.12:3930 | disk        | mapper/vagrant--vg-root | used               | 11779076096 |
| tiflash | 10.0.1.12:3930 | disk        | mapper/vagrant--vg-root | free-percent       | 0.82        |
| tiflash | 10.0.1.12:3930 | disk        | mapper/vagrant--vg-root | used-percent       | 0.18        |
| tiflash | 10.0.1.12:3930 | memory      | memory                  | capacity           | 3147071488  |
+---------+----------------+-------------+-------------------------+--------------------+-------------+
18 rows in set (0.01 sec)

3. What did you see instead (Required)

The result rows miss the value of disk for DEVICE_TYPE.

image

4. What is your TiDB version? (Required)

v4.0.9 and v5.0.0-rc

More

This bug is reported by the user from the asktug: https://asktug.com/t/topic/69179/36

After investigating, the reason is the user's disk is special that starts with vda in the output of command lsblk, while the tiflash doesn't recognize this kind of prefix.

image

@baurine baurine added the type/bug This issue is a bug. label Apr 15, 2021
@baurine
Copy link
Contributor Author

baurine commented Apr 15, 2021

/cc @leiysky

@baurine baurine changed the title INFORMATION_SCHEMA.CLUSTER_HARDWARE miss the disk information for tiflash node INFORMATION_SCHEMA.CLUSTER_HARDWARE misses the disk information for tiflash node Apr 15, 2021
@An0nymous0
Copy link

image

vda and vdb

@leiysky
Copy link
Contributor

leiysky commented Aug 9, 2021

This issue has been fixed in TiDB 5.1.1.

https://docs.pingcap.com/tidb/stable/release-5.1.1

image

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

Please check whether the issue should be labeled with 'affects-x.y' or 'fixes-x.y.z', and then remove 'needs-more-info' label.

@lakevilladom
Copy link

Bug still exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/moderate sig/diagnosis SIG: Diagnosis type/bug This issue is a bug.
Projects
None yet
Development

No branches or pull requests

6 participants