BR download / import give up retry when meeting retryable gRPC errors #27421
Labels
affects-4.0
This bug affects 4.0.x versions.
affects-5.0
This bug affects 5.0.x versions.
affects-5.1
This bug affects 5.1.x versions.
affects-5.2
This bug affects 5.2.x versions.
component/br
This issue is related to BR of TiDB.
severity/major
sig/migrate
type/bug
This issue is a bug.
Bug Report
1. Minimal reproduce step (Required)
Inject a fail point at here, by
status.Error
tidb/br/pkg/restore/import.go
Lines 315 to 319 in 086a63f
for example:
Then execute restore with
GO_FAILPOINTS=github.com/pingcap/tidb/br/pkg/restore/restore-gRPC-error=1*return(true)
.2. What did you expect to see? (Required)
The error should be retried, due to
tidb/br/pkg/restore/backoff.go
Lines 68 to 71 in 086a63f
3. What did you see instead (Required)
[2021/08/20 13:39:43.652 +08:00] [WARN] [backoff.go:76] ["unexcepted error, stop to retry"] [error="rpc error: code = Unavailable desc = the connection to TiKV has been cut by a neko, meow :3"]
4. What is your TiDB version? (Required)
The text was updated successfully, but these errors were encountered: