address comments

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
pingcap · Sep 13, 2023 · 80dc190 · 80dc190
1 parent b415837
commit 80dc190
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/dbms/src/Interpreters/Aggregator.cpp b/dbms/src/Interpreters/Aggregator.cpp
@@ -151,7 +151,7 @@ size_t AggregatedDataVariants::getBucketNumberForTwoLevelHashTable(Type type)
     }
 }
 
-void AggregatedDataVariants::setResizeCallbackIfNeeded(size_t thread_num)
+void AggregatedDataVariants::setResizeCallbackIfNeeded(size_t thread_num) const
 {
     if (aggregator)
     {
@@ -672,21 +672,19 @@ ALWAYS_INLINE void Aggregator::executeImplBatch(
     {
         /// For all rows.
         AggregateDataPtr place = aggregates_pool->alloc(0);
-        size_t processed_rows = std::numeric_limits<size_t>::max();
         try
         {
-            for (size_t i = agg_process_info.start_row; i < agg_process_info.start_row + agg_size; ++i)
+            for (size_t i = 0; i < agg_size; ++i)
             {
-                state.emplaceKey(method.data, i, *aggregates_pool, sort_key_containers).setMapped(place);
-                processed_rows = i;
+                state.emplaceKey(method.data, agg_process_info.start_row, *aggregates_pool, sort_key_containers)
+                    .setMapped(place);
+                ++agg_process_info.start_row;
             }
         }
         catch (ResizeException &)
         {
             LOG_INFO(log, "HashTable resize throw ResizeException since the data is already marked for spill");
         }
-        if (processed_rows != std::numeric_limits<size_t>::max())
-            agg_process_info.start_row = processed_rows + 1;
         return;
     }
 

diff --git a/dbms/src/Interpreters/Aggregator.h b/dbms/src/Interpreters/Aggregator.h
@@ -938,7 +938,7 @@ struct AggregatedDataVariants : private boost::noncopyable
 
     void convertToTwoLevel();
 
-    void setResizeCallbackIfNeeded(size_t thread_num);
+    void setResizeCallbackIfNeeded(size_t thread_num) const;
 
 #define APPLY_FOR_VARIANTS_TWO_LEVEL(M)               \
     M(key32_two_level)                                \