Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The block returned by InputStream should obey the max_block_size constraint #3436

Open
windtalker opened this issue Nov 15, 2021 · 0 comments
Open

The block returned by InputStream should obey the max_block_size constraint #3436

windtalker opened this issue Nov 15, 2021 · 0 comments
Labels
severity/moderate type/enhancement Issue or PR for enhancement

Comments

@windtalker
Copy link
Contributor

In TiFlash there is a setting named max_block_size, which means the max number of rows for each block, so the block returned by InputStream should obey this constraint.
Currently, most of the InputStream obeys this constraint except for aggregation and join, the size of block returned by aggregation and join is un-limited, should find a way to fix this.
@windtalker windtalker mentioned this issue Nov 15, 2021
Closed
@windtalker windtalker added type/enhancement Issue or PR for enhancement and removed type/bug Issue for bug labels Dec 14, 2021
@windtalker windtalker mentioned this issue Dec 31, 2021
Closed
@windtalker windtalker mentioned this issue Mar 15, 2022
Merged
12 tasks
@windtalker windtalker mentioned this issue Dec 22, 2022
Open
@windtalker windtalker mentioned this issue Jan 19, 2023
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Jan 20, 2023
@windtalker
max_block_size take effect on NonJoinedBlockInputStream (#6663)
ca13501 
ref #3436
ywqzzy pushed a commit to ywqzzy/tiflash_1 that referenced this issue Feb 13, 2023
@windtalker @ywqzzy
max_block_size take effect on NonJoinedBlockInputStream (pingcap#…
ac062c6 
…6663)

ref pingcap#3436

Signed-off-by: ywqzzy <592838129@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity/moderate type/enhancement Issue or PR for enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@windtalker @fuzhe1989