Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String column decoder reserves much larger memory than needed #7416

Closed
yibin87 opened this issue May 5, 2023 · 0 comments · Fixed by #7418
Closed

String column decoder reserves much larger memory than needed #7416

yibin87 opened this issue May 5, 2023 · 0 comments · Fixed by #7418

Comments

@yibin87
Copy link
Contributor

yibin87 commented May 5, 2023

Bug Report

When decode columns, we use IColumn's reserve(size_t rows) interface to avoid reallocating memories each time. However, for string columns, the element size is not fixed, and we used 64 bytes as default value. This will lead to much larger memory usage when actual element size is much smaller than 64 bytes.
This problem will be worsen for Join operator, since all build side's blocks will be in memory for a while.

@yibin87 yibin87 self-assigned this May 5, 2023
@yibin87 yibin87 changed the title String column decode reserved much larger memory than needed String column decoder reserved much larger memory than needed May 6, 2023
@yibin87 yibin87 changed the title String column decoder reserved much larger memory than needed String column decoder reserves much larger memory than needed May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants