Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support automatically enable the consecutive cache of HashMap for HashAgg #8939

Open
guo-shaoge opened this issue Apr 12, 2024 · 0 comments
Open
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@guo-shaoge
Copy link
Contributor

Enhancement

Consecutive cache of HashMap: check code:

if constexpr (consecutive_keys_optimization)

It's useful when consecutive same key inserting into HashMap, because the cache avoid search HashMap.

But if NDV is big(a.k.a. all keys are different), the consecutive cache is useless and there will be extra copy of key.

So we should detect the NDV automatically and decide whether to use consecutive cache by the workload.

@guo-shaoge guo-shaoge added the type/enhancement The issue or PR belongs to an enhancement. label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

1 participant