tests: Fix RegionBlockReaderTest helper functions (#5899)

[ti-chi-bot]

This is an automated cherry-pick of #5899

Signed-off-by: JaySon-Huang tshent@qq.com

What problem does this PR solve?

Issue Number: ref #5859

Problem Summary:
The helper functions in RegionBlockReaderTestFixture is buggy when testing with primary key columns.

What is changed and how it works?

Fix the testing helper functions.
A pre-split PR for #5879

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• JaySon-Huang
• lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[JaySon-Huang]

/run-all-tests

[JaySon-Huang]

/run-all-tests

[sre-bot]

Coverage for changed files

Filename                                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Storages/Transaction/RowCodec.cpp                                244                34    86.07%          19                 0   100.00%         393                59    84.99%         204                45    77.94%
Storages/Transaction/tests/RowCodecTestUtils.h                    84                 4    95.24%          14                 0   100.00%         173                 1    99.42%          42                 6    85.71%
Storages/Transaction/tests/gtest_region_block_reader.cpp         161                24    85.09%          23                 1    95.65%         295                12    95.93%          44                 5    88.64%
TestUtils/FunctionTestUtils.cpp                                   90                29    67.78%          13                 3    76.92%         134                51    61.94%          42                21    50.00%
TestUtils/FunctionTestUtils.h                                    113                 9    92.04%          33                 0   100.00%         264                 7    97.35%          48                 6    87.50%
TestUtils/TiFlashTestBasic.cpp                                     8                 2    75.00%           2                 0   100.00%          11                 3    72.73%           4                 2    50.00%
TestUtils/TiFlashTestBasic.h                                       4                 0   100.00%           2                 0   100.00%          12                 0   100.00%           2                 0   100.00%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                            704               102    85.51%         106                 4    96.23%        1282               133    89.63%         386                85    77.98%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18361      9787             46.70%    206370  97969        52.53%

full coverage report (for internal network access only)

[JaySon-Huang]

/merge

[ti-chi-bot]

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 3f8b6b7

[ti-chi-bot]

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[sre-bot]

Coverage for changed files

Filename                                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Storages/Transaction/RowCodec.cpp                                244                34    86.07%          19                 0   100.00%         393                59    84.99%         204                45    77.94%
Storages/Transaction/tests/RowCodecTestUtils.h                    84                 4    95.24%          14                 0   100.00%         173                 1    99.42%          42                 6    85.71%
Storages/Transaction/tests/gtest_region_block_reader.cpp         161                24    85.09%          23                 1    95.65%         295                12    95.93%          44                 5    88.64%
TestUtils/FunctionTestUtils.cpp                                   90                29    67.78%          13                 3    76.92%         134                51    61.94%          42                21    50.00%
TestUtils/FunctionTestUtils.h                                    113                 9    92.04%          33                 0   100.00%         264                 7    97.35%          48                 6    87.50%
TestUtils/TiFlashTestBasic.cpp                                     8                 2    75.00%           2                 0   100.00%          11                 3    72.73%           4                 2    50.00%
TestUtils/TiFlashTestBasic.h                                       4                 0   100.00%           2                 0   100.00%          12                 0   100.00%           2                 0   100.00%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                            704               102    85.51%         106                 4    96.23%        1282               133    89.63%         386                85    77.98%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18361      9787             46.70%    206370  97966        52.53%

full coverage report (for internal network access only)

[sre-bot]

Coverage for changed files

Filename                                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Storages/Transaction/RowCodec.cpp                                244                34    86.07%          19                 0   100.00%         393                59    84.99%         204                45    77.94%
Storages/Transaction/tests/RowCodecTestUtils.h                    84                 4    95.24%          14                 0   100.00%         173                 1    99.42%          42                 6    85.71%
Storages/Transaction/tests/gtest_region_block_reader.cpp         161                24    85.09%          23                 1    95.65%         295                12    95.93%          44                 5    88.64%
TestUtils/FunctionTestUtils.cpp                                   90                29    67.78%          13                 3    76.92%         134                51    61.94%          42                21    50.00%
TestUtils/FunctionTestUtils.h                                    113                 9    92.04%          33                 0   100.00%         264                 7    97.35%          48                 6    87.50%
TestUtils/TiFlashTestBasic.cpp                                     8                 2    75.00%           2                 0   100.00%          11                 3    72.73%           4                 2    50.00%
TestUtils/TiFlashTestBasic.h                                       4                 0   100.00%           2                 0   100.00%          12                 0   100.00%           2                 0   100.00%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                            704               102    85.51%         106                 4    96.23%        1282               133    89.63%         386                85    77.98%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18361      9787             46.70%    206370  97953        52.54%

full coverage report (for internal network access only)

[sre-bot]

Coverage for changed files

Filename                                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Storages/Transaction/RowCodec.cpp                                244                34    86.07%          19                 0   100.00%         393                59    84.99%         204                45    77.94%
Storages/Transaction/tests/RowCodecTestUtils.h                    84                 4    95.24%          14                 0   100.00%         173                 1    99.42%          42                 6    85.71%
Storages/Transaction/tests/gtest_region_block_reader.cpp         161                24    85.09%          23                 1    95.65%         295                12    95.93%          44                 5    88.64%
TestUtils/FunctionTestUtils.cpp                                   90                29    67.78%          13                 3    76.92%         134                51    61.94%          42                21    50.00%
TestUtils/FunctionTestUtils.h                                    113                 9    92.04%          33                 0   100.00%         264                 7    97.35%          48                 6    87.50%
TestUtils/TiFlashTestBasic.cpp                                     8                 2    75.00%           2                 0   100.00%          11                 3    72.73%           4                 2    50.00%
TestUtils/TiFlashTestBasic.h                                       4                 0   100.00%           2                 0   100.00%          12                 0   100.00%           2                 0   100.00%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                            704               102    85.51%         106                 4    96.23%        1282               133    89.63%         386                85    77.98%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18361      9787             46.70%    206376  97963        52.53%

full coverage report (for internal network access only)