Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support sm4 by gmssl #6126

Merged
merged 17 commits into from Oct 27, 2022
Merged

support sm4 by gmssl #6126

merged 17 commits into from Oct 27, 2022

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Oct 13, 2022 •
edited

What problem does this PR solve?

Issue Number: close #5953

Problem Summary: TiFlash built with OpenSSL may crash when enable TLS and the problem is still under invetigation.

What is changed and how it works?

Use GmSSL for sm4 encryption algorithm.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 13, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CalvinNeo
  • JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 13, 2022
@lidezhu lidezhu changed the title add GmSSL add GmSSL support Oct 13, 2022
JaySon-Huang
JaySon-Huang reviewed Oct 14, 2022
View reviewed changes
.gitmodules Outdated Show resolved Hide resolved
@lidezhu
Copy link
Contributor Author

lidezhu commented Oct 14, 2022

/run-all-tests

@lidezhu
Copy link
Contributor Author

lidezhu commented Oct 14, 2022

/run-build-release comment=true

@lidezhu
Copy link
Contributor Author

lidezhu commented Oct 25, 2022

/run-integration-test

@lidezhu lidezhu changed the title add GmSSL support support sm4 by gmssl Oct 25, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Oct 25, 2022

/run-unit-test

1 similar comment
@lidezhu
Copy link
Contributor Author

lidezhu commented Oct 25, 2022

/run-unit-test

@lidezhu
Copy link
Contributor Author

lidezhu commented Oct 25, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Oct 26, 2022

download tiflash binary(linux arm64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tiflash/master/a00b7fdb0c133bd962a7292d99ad565a73ad1a47/centos7/tiflash-linux-arm64.tar.gz

@lidezhu
Copy link
Contributor Author

lidezhu commented Oct 26, 2022

/run-build-arm64-release comment=true

@lidezhu
Copy link
Contributor Author

lidezhu commented Oct 26, 2022

/run-build-release comment=true

@lidezhu
Copy link
Contributor Author

lidezhu commented Oct 26, 2022

/run-build-release comment=true

@lidezhu
Copy link
Contributor Author

lidezhu commented Oct 26, 2022

/run-build-arm64-release comment=true

@sre-bot
Copy link
Collaborator

sre-bot commented Oct 26, 2022

download tiflash binary(linux amd64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tiflash/004f5430cc97ffc515c47c406325f35d4a3461e6/centos7/tiflash-linux-amd64.tar.gz

@sre-bot
Copy link
Collaborator

sre-bot commented Oct 26, 2022

download tiflash binary(linux arm64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tiflash/master/004f5430cc97ffc515c47c406325f35d4a3461e6/centos7/tiflash-linux-arm64.tar.gz

@lidezhu
Copy link
Contributor Author

lidezhu commented Oct 26, 2022

/run-all-tests

JaySon-Huang
JaySon-Huang approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 27, 2022
CalvinNeo
CalvinNeo approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 27, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Oct 27, 2022

/merge

@ti-chi-bot
Copy link
Member

@lidezhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5dd38e0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 27, 2022
@ti-chi-bot ti-chi-bot merged commit dc75250 into pingcap:master Oct 27, 2022
@lidezhu lidezhu deleted the add-gmssl branch October 27, 2022 06:08
@lidezhu lidezhu mentioned this pull request Oct 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@flowbehappy flowbehappy Awaiting requested review from flowbehappy

@JinheLin JinheLin Awaiting requested review from JinheLin

@hehechen hehechen Awaiting requested review from hehechen

Assignees
No one assigned
Labels
release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TiFlash crash when open tls
5 participants
@lidezhu @ti-chi-bot @JaySon-Huang @sre-bot @CalvinNeo