Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tls ipv6 metric #6736

Merged
merged 7 commits into from
Feb 8, 2023
Merged

fix tls ipv6 metric #6736

merged 7 commits into from
Feb 8, 2023

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Feb 6, 2023 •
edited

What problem does this PR solve?

Issue Number: close #6734

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 6, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • SeaRise

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 6, 2023
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Feb 6, 2023

/run-build-release x86

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Feb 6, 2023

/run-build-release comment=true

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Feb 6, 2023

/run-build-release

2 similar comments
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Feb 6, 2023

/run-build-release

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Feb 6, 2023

/run-build-release

@sre-bot
Copy link
Collaborator

sre-bot commented Feb 6, 2023

download tiflash binary(linux amd64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tiflash/a2c7691daef06ac215774e6385489797515f8216/centos7/tiflash-linux-amd64.tar.gz

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-triage-completed needs-cherry-pick-release-6.5 needs-cherry-pick-release-6.6 and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-linked-issue do-not-merge/needs-triage-completed labels Feb 8, 2023
LittleFall
LittleFall approved these changes Feb 8, 2023
View reviewed changes
dbms/src/Server/MetricsPrometheus.cpp Outdated Show resolved Hide resolved
dbms/src/Server/MetricsPrometheus.cpp Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 8, 2023
SeaRise
SeaRise approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 8, 2023
ywqzzy and others added 3 commits February 8, 2023 15:36
@ywqzzy
update
88c5791
@ywqzzy @LittleFall
Update dbms/src/Server/MetricsPrometheus.cpp
4f3fe15 
Co-authored-by: Zhi Qi <30543181+LittleFall@users.noreply.github.com>
@ywqzzy @LittleFall
Update dbms/src/Server/MetricsPrometheus.cpp
21e7dcc 
Co-authored-by: Zhi Qi <30543181+LittleFall@users.noreply.github.com>
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Feb 8, 2023

/merge

@ti-chi-bot
Copy link
Member

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 21e7dcc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 8, 2023
@ti-chi-bot ti-chi-bot merged commit 50e025a into pingcap:master Feb 8, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 9, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #6783.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Feb 9, 2023
@ywqzzy @ti-chi-bot
This is an automated cherry-pick of pingcap#6736
fa3300a 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this pull request Feb 9, 2023
@ti-chi-bot
fix tls ipv6 metric (#6736) (#6783)
4816a7c 
close #6734
guo-shaoge pushed a commit to guo-shaoge/tiflash that referenced this pull request Feb 10, 2023
@ywqzzy @guo-shaoge
fix tls ipv6 metric (pingcap#6736)
5b033a1 
close pingcap#6734
ywqzzy added a commit to ywqzzy/tiflash_1 that referenced this pull request Feb 13, 2023
@ywqzzy
fix tls ipv6 metric (pingcap#6736)
1d53d8d 
close pingcap#6734

Signed-off-by: ywqzzy <592838129@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeaRise SeaRise SeaRise approved these changes

@LittleFall LittleFall LittleFall approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tiflash can't startup after enable tls and set preferIPv6 to True
6 participants
@ywqzzy @ti-chi-bot @sre-bot @SeaRise @LittleFall @jebter