New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix row key not in standard format (#7901) #7910
Merged
ti-chi-bot
merged 3 commits into
pingcap:release-6.1
from
ti-chi-bot:cherry-pick-7901-to-release-6.1
Aug 9, 2023
Merged
fix row key not in standard format (#7901) #7910
ti-chi-bot
merged 3 commits into
pingcap:release-6.1
from
ti-chi-bot:cherry-pick-7901-to-release-6.1
Aug 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
12 tasks
ti-chi-bot
added
release-note
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
type/cherry-pick-for-release-6.1
labels
Aug 8, 2023
ti-chi-bot
bot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Aug 8, 2023
ti-chi-bot
bot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Aug 8, 2023
ti-chi-bot
added
the
cherry-pick-approved
Cherry pick PR approved by release team.
label
Aug 8, 2023
/run-all-tests |
JaySon-Huang
approved these changes
Aug 9, 2023
lidezhu
approved these changes
Aug 9, 2023
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, lidezhu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
cherry-pick-approved
Cherry pick PR approved by release team.
lgtm
release-note
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
type/cherry-pick-for-release-6.1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #7901
What problem does this PR solve?
Issue Number: close #3099 close #7762
Problem Summary: For int handle, the standard row key format should be t{tidb_id}_r{row_id}, but the cluster may generate keys not strictly adhere to this format. For example, it may append a
0x00
to the encoded value.When tiflash decode the key, it will ignore the suffix
0x00
and may get an invalid row key value.What is changed and how it works?
For row key which size is larger than the standard format, we add 1 on the decoded int key value.
This is ok, because
Note if the decoded int value is
Int64::max_value
, it is a value generated by tiflash itself which is RowKeyValue::INT_HANDLE_MAX_KEY. This is a special key to means +inf, so we can just ignore it.Check List
Tests
Side effects
Documentation
Release note