Pipeline: use notify instead of polling for ResultQueue
#9065
Conversation
Co-authored-by: Liqi Geng <gengliqiii@gmail.com>
|
/test all |
Co-authored-by: Rossi Sun <zanmato1984@gmail.com>
Co-authored-by: Rossi Sun <zanmato1984@gmail.com>
Co-authored-by: Rossi Sun <zanmato1984@gmail.com>
| return; | ||
| tmp = (*result_queue).get(); | ||
| } | ||
| assert(tmp); |
There was a problem hiding this comment.
Why tmp is always not nullptr here?
There was a problem hiding this comment.
Because if isWaitMode() is false, the result_queue must not be nullptr
| @@ -86,7 +86,7 @@ void UnorderedSourceOp::operatePrefixImpl() | |||
| else | |||
| { | |||
| // Poll and check if the RuntimeFilters is ready in the WaitReactor. | |||
| TaskScheduler::instance->submitToWaitReactor(std::make_unique<RFWaitTask>( | |||
| TaskScheduler::instance->submit(std::make_unique<RFWaitTask>( | |||
There was a problem hiding this comment.
Why change this? In my understanding, in submit, it will still call submitToWaitReactor?
There was a problem hiding this comment.
It's just a simple refactoring
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gengliqi, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
@SeaRise: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: ref #8869
Problem Summary:
What is changed and how it works?
SharedQueueinstead ofResultQueuein join restore probe stage.ResultQueueandGetResultSinkPipelineExecutorContext::consumeFordue to conflict withResultQueue::notify.Check List
Tests
Side effects
Documentation
Release note