Skip to content

Commit

Permalink
s3(ticdc): do not report unretryable error when initializing s3 stora…
Browse files Browse the repository at this point in the history
…ge (#11312)

close #11311
  • Loading branch information
sdojjy committed Jun 14, 2024
1 parent 999d393 commit 90da67d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/redo/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -202,12 +202,12 @@ func initExternalStorageForTest(ctx context.Context, uri url.URL) (storage.Exter
if ConsistentStorage(uri.Scheme) == consistentStorageS3 && len(uri.Host) == 0 {
// TODO: this branch is compatible with previous s3 logic and will be removed
// in the future.
return nil, errors.WrapChangefeedUnretryableErr(errors.ErrStorageInitialize,
return nil, errors.WrapError(errors.ErrStorageInitialize,
errors.Errorf("please specify the bucket for %+v", uri))
}
s, err := util.GetExternalStorageFromURI(ctx, uri.String())
if err != nil {
return nil, errors.WrapChangefeedUnretryableErr(errors.ErrStorageInitialize, err)
return nil, errors.WrapError(errors.ErrStorageInitialize, err)
}
return s, nil
}
Expand Down

0 comments on commit 90da67d

Please sign in to comment.