-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make more linters really happy #2162
Comments
cc: @amyangfei @leoppro @overvenus While reading the code, I noticed that we have some unnecessary type conversion code, so I would like to turn on the |
/assign I am working on this. |
I found in the process of reading the code that a lot of our code is too long for one screen to read easily. So I suggest we use lint to control the length of each line of code. |
There are many parameters in our code that are not used. We can use unparam to detect them! Original idea from #2309 (comment). cc: @amyangfei |
Description
Currently, we use "golangci-lint" to execute some linters, but due to some reasons, the entire project code may not really pass some necessary linters.
This issue is for everyone to work together to pass some necessary linters for this project. The specific parameters that need to be supported are shown in the task list below.
Related Information
Task List
If there are more necessary linter you would like to enable, please feel free to comment.
The text was updated successfully, but these errors were encountered: