Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more linters really happy #2162

Closed
2 of 6 tasks
hi-rustin opened this issue Jun 25, 2021 · 4 comments
Closed
2 of 6 tasks

Make more linters really happy #2162

hi-rustin opened this issue Jun 25, 2021 · 4 comments
Assignees
Labels
difficulty/easy Easy task. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. subject/new-feature Denotes an issue or pull request adding a new feature. type/enhancement This is a enhancement PR

Comments

@hi-rustin
Copy link
Member

hi-rustin commented Jun 25, 2021

Description

Currently, we use "golangci-lint" to execute some linters, but due to some reasons, the entire project code may not really pass some necessary linters.
This issue is for everyone to work together to pass some necessary linters for this project. The specific parameters that need to be supported are shown in the task list below.

Related Information

Task List

If there are more necessary linter you would like to enable, please feel free to comment.

@hi-rustin hi-rustin added the subject/new-feature Denotes an issue or pull request adding a new feature. label Jun 25, 2021
@hi-rustin
Copy link
Member Author

cc: @amyangfei @leoppro @overvenus

While reading the code, I noticed that we have some unnecessary type conversion code, so I would like to turn on the unconvert plugin to improve the code quality. What do you think?

@hi-rustin
Copy link
Member Author

/assign

I am working on this.

@hi-rustin
Copy link
Member Author

I found in the process of reading the code that a lot of our code is too long for one screen to read easily. So I suggest we use lint to control the length of each line of code.

@hi-rustin hi-rustin added difficulty/easy Easy task. good-first-issue help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jul 16, 2021
@ti-chi-bot ti-chi-bot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. and removed good-first-issue labels Jul 16, 2021
@hi-rustin
Copy link
Member Author

There are many parameters in our code that are not used. We can use unparam to detect them!

Original idea from #2309 (comment). cc: @amyangfei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty/easy Easy task. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. subject/new-feature Denotes an issue or pull request adding a new feature. type/enhancement This is a enhancement PR
Projects
None yet
Development

No branches or pull requests

3 participants