Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement a limit memory buffer #271

Closed
july2993 opened this issue Feb 19, 2020 · 0 comments · Fixed by #284
Closed

implement a limit memory buffer #271

july2993 opened this issue Feb 19, 2020 · 0 comments · Fixed by #284
Labels
component/replica-model Replication model component. priority/p0 Issue with the highest priority, should be resolved as soon as possible. subject/performance Denotes an issue or pull request is related to replication performance.

Comments

@july2993
Copy link
Contributor

july2993 commented Feb 19, 2020 •
edited

https://github.com/pingcap/ticdc/blob/d2621b3f0f65f33567fa6bf772b93e8b2aee1128/cdc/puller/buffer.go#L40

currently, we will stop to consume kv events from tikv once the rest pipeline is slow.

implement a limit memory buffer and use it to buffer event from tikv, we should consume events from tikv ASAP and fail the changfeed if the rest pipeline of feed is too slow.
@amyangfei amyangfei added priority/p0 Issue with the highest priority, should be resolved as soon as possible. component/replica-model Replication model component. subject/performance Denotes an issue or pull request is related to replication performance. labels Feb 19, 2020
@july2993 july2993 mentioned this issue Feb 24, 2020
Merged
amyangfei pushed a commit to amyangfei/tiflow that referenced this issue May 6, 2022
@liuzix
lib: fix key encoding for WorkerStatus (pingcap#271)
b91e8b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/replica-model Replication model component. priority/p0 Issue with the highest priority, should be resolved as soon as possible. subject/performance Denotes an issue or pull request is related to replication performance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add mem buffer for kv event. july2993/ticdc
2 participants
@amyangfei @july2993