Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fallback resolvedTs event skips the lock resolving unexpectly #3061

Closed
Tracked by #2872
maxshuang opened this issue Oct 14, 2021 · 0 comments · Fixed by #3062
Closed
Tracked by #2872

fallback resolvedTs event skips the lock resolving unexpectly #3061

maxshuang opened this issue Oct 14, 2021 · 0 comments · Fixed by #3062
Assignees
@maxshuang
Labels
area/ticdc Issues or PRs related to TiCDC. component/kv-client TiKV kv log client component. severity/moderate This is a moderate bug. type/bug This is a bug.
Projects
Question and Bug Reports

Comments

@maxshuang
Copy link
Contributor

maxshuang commented Oct 14, 2021 •
edited
Loading

This bug is caused by following reason:
(1) when region merge occur, a new stream with new region_worker will be created. Then region_worker.rtsManager will be empty;
(2) if merged region has some fallback prewrite lock in it, the resolvedTs event will fall back last checkpointTs and will be ignored. Then resolve lock logic can't trigger for region_worker.rtsManager has no record for that region.
@maxshuang maxshuang mentioned this issue Oct 14, 2021
Open
2 tasks
@maxshuang maxshuang changed the title Also use sinceLastEvent as a check condition for lock resolving fallback resolvedTs event skips the lock resolving unexpectly Oct 14, 2021
@maxshuang maxshuang mentioned this issue Oct 14, 2021
Merged
@maxshuang maxshuang self-assigned this Oct 15, 2021
@maxshuang maxshuang added severity/moderate This is a moderate bug. type/bug This is a bug. component/kv-client TiKV kv log client component. labels Oct 15, 2021
@github-actions github-actions bot added this to Need Triage in Question and Bug Reports Oct 15, 2021
maxshuang pushed a commit that referenced this issue Oct 16, 2021
fix(kvclient): fix the problem that region merging would block the pr…
8a884cb 
…ogress of resolveLock.

close  #3061
Question and Bug Reports automation moved this from Need Triage to Done Oct 19, 2021
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this issue Oct 19, 2021
@ti-chi-bot
fix(kvclient): fix the problem that region merging would block the pr…
5ff7e6a 
…ogress of resolveLock.

close  pingcap#3061
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this issue Oct 19, 2021
@ti-chi-bot
fix(errors): fix error message wrong
3037939 
close  pingcap#3061
@ti-chi-bot ti-chi-bot mentioned this issue Oct 19, 2021
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this issue Oct 19, 2021
@ti-chi-bot
fix(kvclient): fix the problem that region merging would block the pr…
c7f0ce4 
…ogress of resolveLock.

close  pingcap#3061
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this issue Oct 19, 2021
@ti-chi-bot
fix(errors): fix error message wrong
dbebe69 
close  pingcap#3061
@ti-chi-bot ti-chi-bot mentioned this issue Oct 19, 2021
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this issue Oct 19, 2021
@ti-chi-bot
fix(kvclient): fix the problem that region merging would block the pr…
d2be754 
…ogress of resolveLock.

close  pingcap#3061
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this issue Oct 19, 2021
@ti-chi-bot
fix(errors): fix error message wrong
c3caa99 
close  pingcap#3061
@ti-chi-bot ti-chi-bot mentioned this issue Oct 19, 2021
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this issue Oct 19, 2021
@ti-chi-bot
fix(kvclient): fix the problem that region merging would block the pr…
4d623ad 
…ogress of resolveLock.

close  pingcap#3061
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this issue Oct 19, 2021
@ti-chi-bot
fix(errors): fix error message wrong
7f98a83 
close  pingcap#3061
@ti-chi-bot ti-chi-bot mentioned this issue Oct 19, 2021
Merged
@3AceShowHand 3AceShowHand mentioned this issue Jan 13, 2022
Closed
@AkiraXie AkiraXie added the area/ticdc Issues or PRs related to TiCDC. label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxshuang maxshuang

Labels
area/ticdc Issues or PRs related to TiCDC. component/kv-client TiKV kv log client component. severity/moderate This is a moderate bug. type/bug This is a bug.
Projects
Question and Bug Reports
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(kvclient): fix region merging would block the progress of resolveLock
2 participants
@maxshuang @AkiraXie