Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some metrics of Syncer is not updated if no query-status #4281

Closed
lance6716 opened this issue Jan 12, 2022 · 0 comments · Fixed by #4330
Closed

some metrics of Syncer is not updated if no query-status #4281

lance6716 opened this issue Jan 12, 2022 · 0 comments · Fixed by #4330
Assignees
@lance6716
Labels
affects-5.3 affects-5.4 area/dm Issues or PRs related to DM. severity/major This is a major bug. type/bug This is a bug.
Projects
Question and Bug Reports

Comments

@lance6716
Copy link
Contributor

lance6716 commented Jan 12, 2022 •
edited
Loading

What did you do?

  • dm_syncer_remaining_time
  • dm_syncer_binlog_pos{"master"}
  • dm_syncer_binlog_file{"master"}

these metrics is updated in printStatus

tiflow/dm/syncer/status.go

Line 125 in ac3d76d

metrics.RemainingTimeGauge.WithLabelValues(s.cfg.Name, s.cfg.SourceID, s.cfg.WorkerName).Set(float64(remainingSeconds))
and printStatus will only be called by query-status from user or internal. They should be periodically updated in background.

this bug is introduced in pingcap/dm#2076
@lance6716 lance6716 added type/bug This is a bug. area/dm Issues or PRs related to DM. labels Jan 12, 2022
@github-actions github-actions bot added this to Need Triage in Question and Bug Reports Jan 12, 2022
@niubell niubell added the severity/minor This is a minor bug. label Jan 12, 2022
@niubell niubell assigned niubell and dsdashun and unassigned niubell Jan 13, 2022
@lance6716 lance6716 assigned lance6716 and unassigned dsdashun Jan 14, 2022
@lance6716 lance6716 added severity/major This is a major bug. and removed severity/minor This is a minor bug. labels Jan 14, 2022
@lance6716 lance6716 mentioned this issue Jan 14, 2022
Merged
Question and Bug Reports automation moved this from Need Triage to Done Jan 14, 2022
ti-chi-bot pushed a commit that referenced this issue Jan 14, 2022
@lance6716
source_worker(dm): peroidically update source metrics background (#4330)
d24f962 
close #4281
This was referenced Jan 14, 2022
Merged
Merged
@niubell niubell mentioned this issue Jan 14, 2022
Merged
14 tasks
ti-chi-bot added a commit that referenced this issue Jan 14, 2022
@ti-chi-bot
source_worker(dm): peroidically update source metrics background (#4330…
aaea432 
…) (#4333)

close #4281
ti-chi-bot added a commit that referenced this issue Jan 16, 2022
@ti-chi-bot
source_worker(dm): peroidically update source metrics background (#4330…
9779df7 
…) (#4332)

close #4281
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this issue Jan 20, 2022
@lance6716 @zhaoxinyu
source_worker(dm): peroidically update source metrics background (pin…
b54d030 
…gcap#4330)

close pingcap#4281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lance6716 lance6716

Labels
affects-5.3 affects-5.4 area/dm Issues or PRs related to DM. severity/major This is a major bug. type/bug This is a bug.
Projects
Question and Bug Reports
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

source_worker(dm): peroidically update source metrics background lance6716/ticdc
4 participants
@dsdashun @lance6716 @jebter @niubell