Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequence appears in TiCDC ineligible table list #4552

Closed
overvenus opened this issue Feb 10, 2022 · 1 comment · Fixed by #4563
Closed

Sequence appears in TiCDC ineligible table list #4552

overvenus opened this issue Feb 10, 2022 · 1 comment · Fixed by #4563
Assignees
Labels

Comments

@overvenus
Copy link
Member

overvenus commented Feb 10, 2022

What did you do?

mysql> CREATE SEQUENCE SEQ_TEST_NO INCREMENT BY 1 START WITH 1 MAXVALUE 999999999999999 NOMINVALUE CYCLE NOCACHE;

$ bin/cdc cli changefeed create \
    --sink-uri="blackhole://" -c "blackhole-seq"
    --no-confirm

[WARN] some tables are not eligible to replicate, []model.TableName{model.TableName{Schema:"test", Table:"SEQ_TEST_NO ", TableID:0, IsPartition:false}}
Create changefeed successfully!
ID: blackhole-seq
Info: {"sink-uri":"blackhole://","opts":{},"create-time":"2022-02-10T11:32:08.692371203+08:00","start-ts":431086351275786296,"target-ts":0,"admin-job-type":0,"sort-engine":"unified","sort-dir":"","config":{"case-sensitive":true,"enable-old-value":true,"force-replicate":false,"check-gc-safe-point":true,"filter":{"rules":["test.*"],"ignore-txn-start-ts":[1,2]},"mounter":{"worker-num":16},"sink":{"dispatchers":null,"protocol":"","column-selectors":null},"cyclic-replication":{"enable":false,"replica-id":0,"filter-replica-ids":null,"id-buckets":0,"sync-ddl":false},"scheduler":{"type":"table-number","polling-time":-1},"consistent":{"level":"none","max-log-size":64,"flush-interval":1000,"storage":""}},"state":"normal","error":null,"sync-point-enabled":false,"sync-point-interval":600000000000,"creator-version":"v5.4.0-alpha"}
DDL Job and Table Info
{
    "id": 20536,
    "type": 34,
    "schema_id": 20531,
    "table_id": 20535,
    "schema_name": "test",
    "state": 6,
    "err": null,
    "err_count": 0,
    "row_count": 0,
    "raw_args": null,
    "schema_state": 5,
    "snapshot_ver": 0,
    "real_start_ts": 0,
    "start_ts": 431086310747799612,
    "dependency_id": 0,
    "query": "CREATE SEQUENCE SEQ_TEST_NO INCREMENT BY 1 START WITH 1 MAXVALUE 999999999999999 NOMINVALUE CYCLE NOCACHE",
    "binlog": {
        "SchemaVersion": 10327,
        "DBInfo": null,
        "TableInfo": {
            "id": 20535,
            "name": {
                "O": "SEQ_TEST_NO",
                "L": "seq_test_no"
            },
            "charset": "",
            "collate": "",
            "cols": null,
            "index_info": null,
            "constraint_info": null,
            "fk_info": null,
            "state": 5,
            "pk_is_handle": false,
            "is_common_handle": false,
            "common_handle_version": 0,
            "comment": "",
            "auto_inc_id": 0,
            "auto_id_cache": 0,
            "auto_rand_id": 0,
            "max_col_id": 0,
            "max_idx_id": 0,
            "max_cst_id": 0,
            "update_timestamp": 431086310761168915,
            "ShardRowIDBits": 0,
            "max_shard_row_id_bits": 0,
            "auto_random_bits": 0,
            "pre_split_regions": 0,
            "partition": null,
            "compression": "",
            "view": null,
            "sequence": {
                "sequence_start": 1,
                "sequence_cache": false,
                "sequence_cycle": true,
                "sequence_min_value": 1,
                "sequence_max_value": 999999999999999,
                "sequence_increment": 1,
                "sequence_cache_value": 0,
                "sequence_comment": ""
            },
            "Lock": null,
            "version": 4,
            "tiflash_replica": null,
            "is_columnar": false,
            "temp_table_type": 0,
            "cache_table_status": 0,
            "policy_ref_info": null,
            "stats_options": null
        },
        "FinishedTS": 431086310774276154,
        "MultipleTableInfos": null
    },
    "version": 1,
    "reorg_meta": null,
    "multi_schema_info": null,
    "priority": 0
}
{
 "id": 20535,
 "name": {
  "O": "SEQ_TEST_NO",
  "L": "seq_test_no"
 },
 "charset": "",
 "collate": "",
 "cols": null,
 "index_info": null,
 "constraint_info": null,
 "fk_info": null,
 "state": 5,
 "pk_is_handle": false,
 "is_common_handle": false,
 "common_handle_version": 0,
 "comment": "",
 "auto_inc_id": 0,
 "auto_id_cache": 0,
 "auto_rand_id": 0,
 "max_col_id": 0,
 "max_idx_id": 0,
 "max_cst_id": 0,
 "update_timestamp": 431086310761168915,
 "ShardRowIDBits": 0,
 "max_shard_row_id_bits": 0,
 "auto_random_bits": 0,
 "pre_split_regions": 0,
 "partition": null,
 "compression": "",
 "view": null,
 "sequence": {
  "sequence_start": 1,
  "sequence_cache": false,
  "sequence_cycle": true,
  "sequence_min_value": 1,
  "sequence_max_value": 999999999999999,
  "sequence_increment": 1,
  "sequence_cache_value": 0,
  "sequence_comment": ""
 },
 "Lock": null,
 "version": 4,
 "tiflash_replica": null,
 "is_columnar": false,
 "temp_table_type": 0,
 "cache_table_status": 0,
 "policy_ref_info": null,
 "stats_options": null
}

What did you expect to see?

Base on TiCDC doc, we should ignore SEQUENCE DDL, so we should also ignore its data (include table info).

What did you see instead?

See above.

Versions of the cluster

Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

TiCDC version (execute cdc version):

v5.4.0
@overvenus overvenus added type/bug This is a bug. component/ddl DDL component. area/ticdc Issues or PRs related to TiCDC. labels Feb 10, 2022
@github-actions github-actions bot added this to Need Triage in Question and Bug Reports Feb 10, 2022
@overvenus overvenus added component/metrics-logging Metrics and logging component. severity/minor This is a minor bug. labels Feb 10, 2022
@overvenus overvenus moved this from Need Triage to In Progress in Question and Bug Reports Feb 10, 2022
@overvenus overvenus self-assigned this Feb 10, 2022
@overvenus
Copy link
Member Author

Cc #4559

Question and Bug Reports automation moved this from In Progress to Done Feb 23, 2022
ti-chi-bot pushed a commit that referenced this issue Feb 23, 2022
overvenus added a commit to overvenus/ticdc that referenced this issue Apr 14, 2022
overvenus added a commit to ti-chi-bot/tiflow that referenced this issue Apr 27, 2022
close pingcap#4552

Signed-off-by: Neil Shen <overvenus@gmail.com>
overvenus added a commit to ti-chi-bot/tiflow that referenced this issue Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

1 participant