Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some bugs when TiCDC setting the timezone #8798

Closed
2 of 6 tasks
hi-rustin opened this issue Apr 17, 2023 · 2 comments
Closed
2 of 6 tasks

Some bugs when TiCDC setting the timezone #8798

hi-rustin opened this issue Apr 17, 2023 · 2 comments
Labels
affects-6.5 affects-7.1 area/ticdc Issues or PRs related to TiCDC. severity/moderate This is a moderate bug. type/bug This is a bug.

Comments

@hi-rustin
Copy link
Member

hi-rustin commented Apr 17, 2023

What did you do?

Set the timezone to TiCDC server and sink-uri. How does TiCDC set the time zone internally?

What did you expect to see?

TiCDC uses timezone correctly.

What did you see instead?

  1. We unescape the timezone value twice.
  2. We use the wrong ctx when we get the timezone.
  3. We should not suggest users use CST to create the changefeed in docs.
  4. We should not suggest users use time-zone="" in sink-uri.
  5. Should we only keep the time-zone from the sink-uri? Considering multi-tenancy, we should not use server configurations.
  6. TiCDC can not handle the timezone for some DDLs correctly. We need to add docs for it.

Versions of the cluster

TiCDC version (execute cdc version):

v6.5.1
@hi-rustin hi-rustin added type/bug This is a bug. area/ticdc Issues or PRs related to TiCDC. labels Apr 17, 2023
@github-actions github-actions bot added this to Need Triage in Question and Bug Reports Apr 17, 2023
@hi-rustin hi-rustin added severity/moderate This is a moderate bug. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Apr 17, 2023
@hi-rustin hi-rustin added affects-6.5 affects-7.1 and removed needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Apr 21, 2023
@nongfushanquan
Copy link
Contributor

/close

@ti-chi-bot ti-chi-bot bot closed this as completed May 25, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 25, 2023

@nongfushanquan: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.5 affects-7.1 area/ticdc Issues or PRs related to TiCDC. severity/moderate This is a moderate bug. type/bug This is a bug.
Development

No branches or pull requests

2 participants