Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a parameter to configure the SslConfigs.SSL_ENDPOINT_IDENTIFICATION_ALGORITHM_CONFIG. #8867

Closed
nongfushanquan opened this issue Apr 27, 2023 · 5 comments · Fixed by #8873
Closed

Add a parameter to configure the SslConfigs.SSL_ENDPOINT_IDENTIFICATION_ALGORITHM_CONFIG. #8867

nongfushanquan opened this issue Apr 27, 2023 · 5 comments · Fixed by #8873
Assignees
@hi-rustin
Labels
affects-6.5 affects-7.1 area/ticdc Issues or PRs related to TiCDC. type/enhancement This is a enhancement PR

Comments

@nongfushanquan
Copy link
Contributor

Is your feature request related to a problem?

When using the Kafka scenario for sinking, the user can only enable or disable the TLS feature. However, if the user wishes to enable TLS and set the SslConfigs.SSL_ENDPOINT_IDENTIFICATION_ALGORITHM_CONFIG=" ", there is currently no option available. Therefore, it is suggested to add a parameter that can control this feature.

Describe the feature you'd like

As title described

Describe alternatives you've considered

No response

Teachability, Documentation, Adoption, Migration Strategy

No response
@nongfushanquan nongfushanquan added the type/feature Issues about a new feature label Apr 27, 2023
@nongfushanquan
Copy link
Contributor Author

/assign @hi-rustin

@hi-rustin hi-rustin mentioned this issue Apr 27, 2023
Merged
hi-rustin added a commit that referenced this issue May 10, 2023
@hi-rustin
pkg/config(ticdc): Support InsecureSkipVerify option when using tls (#…
71fbfde 
…8873)

close #8867
This was referenced May 10, 2023
Merged
Merged
@nongfushanquan
Copy link
Contributor Author

/label affects-7.1

@nongfushanquan
Copy link
Contributor Author

/label type/enhance

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 10, 2023

@nongfushanquan: The label(s) type/enhance cannot be applied. These labels are supported: duplicate, bug-from-internal-test, bug-from-user, affects-5.1, affects-5.2, affects-5.3, affects-5.4, affects-6.0, affects-6.1, affects-6.2, affects-6.3, affects-6.4, affects-6.5, affects-6.6, affects-7.0, affects-7.1, may-affects-5.1, may-affects-5.2, may-affects-5.3, may-affects-5.4, may-affects-6.0, may-affects-6.1, may-affects-6.2, may-affects-6.3, may-affects-6.4, may-affects-6.5, may-affects-6.6, may-affects-7.0, may-affects-7.1, needs-cherry-pick-release-5.1, needs-cherry-pick-release-5.2, needs-cherry-pick-release-5.3, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.0, needs-cherry-pick-release-6.1, needs-cherry-pick-release-6.2, needs-cherry-pick-release-6.3, needs-cherry-pick-release-6.4, needs-cherry-pick-release-6.5, needs-cherry-pick-release-6.6, needs-cherry-pick-release-7.0, needs-cherry-pick-release-7.1, question, release-blocker, wontfix, require-LGT1, require-LGT3.

In response to this:

/label type/enhance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hi-rustin hi-rustin added type/enhancement This is a enhancement PR and removed type/feature Issues about a new feature labels May 10, 2023
@nongfushanquan
Copy link
Contributor Author

/area ticdc

@ti-chi-bot ti-chi-bot bot added the area/ticdc Issues or PRs related to TiCDC. label May 10, 2023
hi-rustin added a commit to ti-chi-bot/tiflow that referenced this issue May 11, 2023
@hi-rustin
pkg/config(ticdc): Support InsecureSkipVerify option when using tls (p…
ec0153e 
…ingcap#8873)

close pingcap#8867
ti-chi-bot bot pushed a commit that referenced this issue May 11, 2023
@ti-chi-bot
pkg/config(ticdc): Support InsecureSkipVerify option when using tls (#…
2c3b177 
…8873) (#8937)

close #8867
ti-chi-bot bot pushed a commit that referenced this issue May 17, 2023
@ti-chi-bot
pkg/config(ticdc): Support InsecureSkipVerify option when using tls (#…
dabd016 
…8873) (#8936)

close #8867
@nongfushanquan nongfushanquan mentioned this issue May 25, 2023
Merged
16 tasks
@nongfushanquan nongfushanquan mentioned this issue Jun 9, 2023
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hi-rustin hi-rustin

Labels
affects-6.5 affects-7.1 area/ticdc Issues or PRs related to TiCDC. type/enhancement This is a enhancement PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pkg/config(ticdc): Support InsecureSkipVerify option when using tls hi-rustin/tiflow
2 participants
@hi-rustin @nongfushanquan