Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticdc still block gc after all changefeeds are removed #9633

Closed
sdojjy opened this issue Aug 22, 2023 · 0 comments · Fixed by #9634
Closed

ticdc still block gc after all changefeeds are removed #9633

sdojjy opened this issue Aug 22, 2023 · 0 comments · Fixed by #9634
Labels
affects-6.5 affects-7.1 area/ticdc Issues or PRs related to TiCDC. severity/major This is a major bug. type/bug This is a bug.

Comments

@sdojjy
Copy link
Member

sdojjy commented Aug 22, 2023

if there is no changefeed, ticdc should remove the gc service from PD

reproduce steps:

  1. add a changefeed
  2. check the gc service checkpoint
 curl http://127.0.0.1:2379/pd/api/v1/gc/safepoint
{
  "service_gc_safe_points": [
    {
      "service_id": "gc_worker",
      "expired_at": 9223372036854775807,
      "safe_point": 443738300532916224
    },
    {
      "service_id": "ticdc-default-15674009460217235928",
      "expired_at": 1692814223,
      "safe_point": 443738442313498625
    }
  ],
  "gc_safe_point": 443738127517876224
}
  1. remove the changefeed
  2. check the gc service checkpoint again
curl http://127.0.0.1:2379/pd/api/v1/gc/safepoint
{
  "service_gc_safe_points": [
    {
      "service_id": "gc_worker",
      "expired_at": 9223372036854775807,
      "safe_point": 443739841939636224
    },
    {
      "service_id": "ticdc-default-15674009460217235928",
      "expired_at": 1692814223,
      "safe_point": 443738442313498625
    }
  ],
  "gc_safe_point": 443738442313498625
}
@sdojjy sdojjy added type/bug This is a bug. area/ticdc Issues or PRs related to TiCDC. labels Aug 22, 2023
@github-actions github-actions bot added this to Need Triage in Question and Bug Reports Aug 22, 2023
@sdojjy sdojjy changed the title ticdc still block gc after all changefeeds removed ticdc still block gc after all changefeeds are removed Aug 22, 2023
@sdojjy sdojjy added severity/moderate This is a moderate bug. severity/major This is a major bug. labels Aug 22, 2023
Question and Bug Reports automation moved this from Need Triage to Done Aug 23, 2023
3AceShowHand pushed a commit to 3AceShowHand/tiflow that referenced this issue Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.5 affects-7.1 area/ticdc Issues or PRs related to TiCDC. severity/major This is a major bug. type/bug This is a bug.
Development

Successfully merging a pull request may close this issue.

1 participant