processor: fix task status is always flushed because of incorrect mod revision cache #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyangfei
added
type/bugfix
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #1017 +/- ##
================================================
- Coverage 32.1359% 31.6826% -0.4534%
================================================
Files 101 101
Lines 11358 11066 -292
================================================
- Hits 3650 3506 -144
+ Misses 7297 7167 -130
+ Partials 411 393 -18 |
|
LGTM |
|
LGTM |
ti-srebot
added
status/LGT2
ti-srebot
approved these changes
Oct 22, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@amyangfei merge failed. |
|
/merge |
|
/run-all-tests |
|
@amyangfei merge failed. |
|
/merge |
3 similar comments
|
/merge |
|
/merge |
|
/merge |
|
/run-all-tests |
|
/merge |
ti-srebot
pushed a commit
to ti-srebot/ticdc
that referenced
this pull request
Oct 22, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #1019 |
amyangfei
added
the
priority/p0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
After investigating the #993, found key
/tidb/cdc/task/status/<capture-id>/<changefeed-id>is always updated when processor callsflushTaskStatusAndPositionThis bug happens since v4.0.5
What is changed and how it works?
The fix is straightforward, check
newModRevisionreturned byAtomicPutTaskStatus,newModRevision=0means status is not updated, we don't update the mod revision cache.Check List
Tests
Related changes
Release note