Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ticdc): enable client auth feature and fix cli_tls_with_auth for pulsar #10724

Merged

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented Mar 6, 2024

What problem does this PR solve?

Issue Number: close #10544

What is changed and how it works?

  1. enable client auth
  2. fix cli_tls_with_auth for pulsar

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`Support client authentication by mutual tls and tidb credentials`.

Copy link
Contributor

ti-chi-bot bot commented Mar 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 6, 2024
@CharlesCheung96
Copy link
Contributor Author

/test all

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Merging #10724 (06a4c16) into master (99b3eb4) will increase coverage by 3.7520%.
Report is 13 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
Components Coverage Δ
cdc 62.0441% <0.0000%> (∅)
dm 51.3020% <ø> (+0.0828%) ⬆️
engine 63.3936% <ø> (+0.0211%) ⬆️
Flag Coverage Δ
unit 57.6739% <0.0000%> (+3.7520%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #10724        +/-   ##
================================================
+ Coverage   53.9219%   57.6739%   +3.7520%     
================================================
  Files           403        853       +450     
  Lines         63655     127451     +63796     
================================================
+ Hits          34324      73506     +39182     
- Misses        26627      48498     +21871     
- Partials       2704       5447      +2743     

@CharlesCheung96
Copy link
Contributor Author

/retest

1 similar comment
@CharlesCheung96
Copy link
Contributor Author

/retest

@CharlesCheung96
Copy link
Contributor Author

/hold util 8.0 released

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2024
@CharlesCheung96 CharlesCheung96 marked this pull request as ready for review March 20, 2024 16:24
@ti-chi-bot ti-chi-bot bot added affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 20, 2024
@CharlesCheung96 CharlesCheung96 changed the title test(ticdc): enable cli_tls_with_auth for pulsar test(ticdc): enable client auth feature and fix cli_tls_with_auth for pulsar Mar 20, 2024
@CharlesCheung96 CharlesCheung96 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2024
@CharlesCheung96
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. release-note-none Denotes a PR that doesn't merit a release note. labels Mar 27, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [asddongmen,hongyunyan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Mar 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-27 02:48:57.522344171 +0000 UTC m=+2036164.544590558: ☑️ agreed by hongyunyan.
  • 2024-03-27 02:54:59.127443562 +0000 UTC m=+2036526.149689950: ☑️ agreed by asddongmen.

@CharlesCheung96
Copy link
Contributor Author

/retest

1 similar comment
@CharlesCheung96
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 034a927 into pingcap:master Mar 27, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(TiCDC) Tracking issue for implement client authentication
3 participants