Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cdc,dm): add prow OWNERS files to controal approving for critial files #10894

Merged
merged 10 commits into from
Jun 4, 2024
Merged

chore(cdc,dm): add prow OWNERS files to controal approving for critial files #10894

merged 10 commits into from
Jun 4, 2024

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Apr 10, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #10895

What is changed and how it works?

add delicate approvers for these files:

  • CDC component:
    • pkg/cmd/util/changefeed.toml
    • cdc/api/v2/*.go but execlude go test files.
  • DM component:
    • dm/master/config.go
    • dm/worker/config.go
    • dm/config/task.go
    • dm/config/source_config.go

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note 

None

@wuhuizuo
chore(cdc,dm): add prow OWNERS files to controal approving for critia…
714ae34 
…l files

add delicate approvers for these files:
- CDC component:
  - pkg/cmd/util/changefeed.toml
  - cdc/api/v2/*.go but execlude go test files.
- DM component:
  - dm/master/config.go
  - dm/worker/config.go
  - dm/config/task.go
  - dm/config/source_config.go
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 10, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 10, 2024
wuhuizuo
wuhuizuo commented Apr 10, 2024
View reviewed changes
dm/config/OWNERS Outdated Show resolved Hide resolved
wuhuizuo
wuhuizuo commented Apr 10, 2024
View reviewed changes
dm/master/OWNERS Outdated Show resolved Hide resolved
wuhuizuo
wuhuizuo commented Apr 10, 2024
View reviewed changes
dm/worker/OWNERS Outdated Show resolved Hide resolved
wuhuizuo
wuhuizuo commented Apr 10, 2024
View reviewed changes
dm/master/OWNERS Outdated Show resolved Hide resolved
wuhuizuo
wuhuizuo commented Apr 10, 2024
View reviewed changes
pkg/cmd/util/OWNERS Outdated Show resolved Hide resolved
wuhuizuo
wuhuizuo commented Apr 10, 2024
View reviewed changes
dm/worker/OWNERS Outdated Show resolved Hide resolved
wuhuizuo
wuhuizuo commented Apr 10, 2024
View reviewed changes
OWNERS_ALIASES Outdated Show resolved Hide resolved
@wuhuizuo wuhuizuo marked this pull request as ready for review April 15, 2024 06:20
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2024
@wuhuizuo
Copy link
Contributor Author

/hold

Wait for the merging decide.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2024
@ti-chi-bot ti-chi-bot bot added the area/dm Issues or PRs related to DM. label May 26, 2024
@wuhuizuo
Copy link
Contributor Author

/cc @kevin-xianliu @benmeadowcroft @yudongusa @easonn7

@wuhuizuo
Copy link
Contributor Author

/cc @kevin-xianliu @benmeadowcroft @yudongusa @easonn7 @flowbehappy @Benjamin2037

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 31, 2024

@wuhuizuo: GitHub didn't allow me to request PR reviews from the following users: kevin-xianliu, BenMeadowcroft, yudongusa, easonn7.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @kevin-xianliu @benmeadowcroft @yudongusa @easonn7 @flowbehappy @Benjamin2037

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wuhuizuo
wuhuizuo commented May 31, 2024
View reviewed changes
OWNERS_ALIASES Outdated Show resolved Hide resolved
@wuhuizuo
Copy link
Contributor Author

/cc lance6716 sdojjy

@ti-chi-bot ti-chi-bot bot requested review from lance6716 and sdojjy May 31, 2024 12:37
Benjamin2037
Benjamin2037 approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-31 13:46:28.220277405 +0000 UTC m=+3043341.977412978: ☑️ agreed by lance6716.
  • 2024-06-04 01:01:25.654150803 +0000 UTC m=+3343039.411286374: ☑️ agreed by Benjamin2037.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2024

@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, flowbehappy, lance6716, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 4, 2024
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Jun 4, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2024
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Jun 4, 2024

/retest

@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Jun 4, 2024

@wuhuizuo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-engine-integration-test e456600 link unknown /test engine-integration-test
Full PR test history. Your PR dashboard.

Flaky case!

@ti-chi-bot ti-chi-bot bot merged commit 99c9d72 into pingcap:master Jun 4, 2024
9 of 10 checks passed
@wuhuizuo wuhuizuo deleted the ci/add-prow-owners-files branch June 4, 2024 06:38
3AceShowHand pushed a commit to wk989898/tiflow that referenced this pull request Jun 4, 2024
@wuhuizuo @3AceShowHand
chore(cdc,dm): add prow OWNERS files to controal approving for critia…
983bde3 
…l files (pingcap#10894)

close pingcap#10895
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@sdojjy sdojjy sdojjy approved these changes

@flowbehappy flowbehappy flowbehappy approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

Assignees
No one assigned
Labels
approved area/dm Issues or PRs related to DM. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strengthen configuration change approval
5 participants
@wuhuizuo @lance6716 @sdojjy @flowbehappy @Benjamin2037