Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*(ticdc): Initialize changefeed/processor asynchronously #10961

Merged
merged 16 commits into from
May 22, 2024

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Apr 24, 2024

What problem does this PR solve?

Issue Number: close #10845

What is changed and how it works?

This PR initiates the processor before ticking it.
These changes can also prevent some data races that occur during processor initialization.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Initialize changefeed/processor asynchronously

close pingcap#10845
# Conflicts:
#	cdc/capture/capture.go
#	cdc/owner/changefeed.go
#	cdc/processor/processor.go
#	cdc/processor/processor_test.go
#	cdc/scheduler/internal/v3/coordinator.go
#	cdc/vars/vars.go
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 24, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 24, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. label Apr 24, 2024
@sdojjy sdojjy self-assigned this Apr 27, 2024
close pingcap#10955, close pingcap#10956
# Conflicts:
#	cdc/async/async_initializer.go
#	cdc/async/async_initializer_test.go
#	cdc/owner/changefeed.go
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2024
# Conflicts:
#	cdc/owner/changefeed.go
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 10, 2024
@ti-chi-bot ti-chi-bot bot added the approved label May 20, 2024
Copy link
Contributor

ti-chi-bot bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label May 20, 2024
Copy link
Contributor

ti-chi-bot bot commented May 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-20 07:45:40.678623662 +0000 UTC m=+2071294.435759234: ☑️ agreed by 3AceShowHand.
  • 2024-05-20 08:47:17.483061014 +0000 UTC m=+2074991.240196587: ☑️ agreed by asddongmen.

@sdojjy
Copy link
Member Author

sdojjy commented May 21, 2024

/retest-required

2 similar comments
@sdojjy
Copy link
Member Author

sdojjy commented May 21, 2024

/retest-required

@sdojjy
Copy link
Member Author

sdojjy commented May 21, 2024

/retest-required

@sdojjy
Copy link
Member Author

sdojjy commented May 21, 2024

/retest-required

@sdojjy
Copy link
Member Author

sdojjy commented May 21, 2024

/retest-required

…release-7.5

# Conflicts:
#	cdc/processor/processor.go
@sdojjy
Copy link
Member Author

sdojjy commented May 21, 2024

/retest-required

@ti-chi-bot ti-chi-bot bot merged commit 40717a8 into pingcap:release-7.5 May 22, 2024
13 checks passed
@sdojjy sdojjy deleted the cp-10832-to-release-7.5 branch May 22, 2024 03:40
@sdojjy sdojjy changed the title *(ticdc): Cp 10832 to release 7.5 *(ticdc): Initialize changefeed/processor asynchronously May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants