Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl_puller (ticdc): handle dorp pk/uk ddl correctly (#10965) #10982

Open
wants to merge 1 commit into
base: release-7.1
Choose a base branch
from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #10965

What problem does this PR solve?

Issue Number: close #10890

What is changed and how it works?

When handling a DDL job in ddlPuller, check if it will transition the table from eligible to ineligible. If so, return an error and stop the changefeed. The error message should provide instructions for the user on how to manage the situation.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
  1. Create a table t1.
CREATE TABLE t1 (
id INT PRIMARY KEY /*T![clustered_index] NONCLUSTERED */,
name VARCHAR(255),
email VARCHAR(255) UNIQUE
);
  1. Drop its primary key.
ALTER TABLE t1 DROP PRIMARY KEY; 
  1. List this changefeed.
-> # ./cdc cli changefeed list 
[
  {
    "id": "test",
    "namespace": "default",
    "summary": {
      "state": "warning",
      "tso": 449299724779651075,
      "checkpoint": "2024-04-24 15:07:11.563",
      "error": {
        "time": "2024-04-24T16:52:17.129593307+08:00",
        "addr": "127.0.0.1:8300",
        "code": "CDC:ErrProcessorUnknown",
        "message": "An eligible table become ineligible after DDL: [alter table t1 drop primary key] it is a dangerous operation. If you want to replicate this ddl, pelase pause the changefeed and update the `force-replicate=true` in the changefeed configuration, then resume the changefeed. Otherwise, will cause data loss."
      }
    }
  }
]
  1. Update the changefeed's config as the instructions in the error message and resume the changefeed. Check the CDC log to confirm if the DDL was replicated.
[2024/04/24 16:55:09.679 +08:00] [INFO] [ddl_manager.go:558] ["execute a ddl event successfully"] [ddl="ALTER TABLE `t1` DROP PRIMARY KEY"] [namespace=default] [changefeed=test] ....

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Fix a bug that might cause the replication of the 'drop primary key' or 'drop unique key' DDL to be lost.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Apr 25, 2024
@ti-chi-bot ti-chi-bot bot added the do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. label Apr 25, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gozssky for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Apr 25, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 25, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 25, 2024

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
jenkins-ticdc/verify 219902f link true /test verify
pull-cdc-integration-storage-test 219902f link true /test cdc-integration-storage-test
pull-cdc-integration-mysql-test 219902f link true /test cdc-integration-mysql-test
pull-cdc-integration-kafka-test 219902f link true /test cdc-integration-kafka-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants