Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticdc: fix ddl exchange partition xxxx with validation to deal with with validation correctly (#10867) #11008

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #10867

What problem does this PR solve?

Issue Number: close #10859

What is changed and how it works?

Determine whether it is necessary to add without validation in the exchange partition.

Check List

Tests

  • Manual test
    test the case mentioned in issue, and check the result in downstream db.
    image

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Make `exchange partition` to deal with clause `with validation` correctly

@ti-chi-bot ti-chi-bot added lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Apr 29, 2024
@ti-chi-bot ti-chi-bot bot added the do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. label Apr 29, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 29, 2024

@hongyunyan: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

ti-chi-bot bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96, hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 29, 2024
@hongyunyan
Copy link
Collaborator

/test cdc-integration-mysql-test

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 29, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. label Apr 29, 2024
@hongyunyan
Copy link
Collaborator

/retest

2 similar comments
@hongyunyan
Copy link
Collaborator

/retest

@hongyunyan
Copy link
Collaborator

/retest

@hongyunyan
Copy link
Collaborator

/test cdc-integration-mysql-test

1 similar comment
@hongyunyan
Copy link
Collaborator

/test cdc-integration-mysql-test

@hongyunyan
Copy link
Collaborator

/test cdc-integration-mysql-test

@ti-chi-bot ti-chi-bot bot merged commit eeb9517 into pingcap:release-7.5 May 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants