Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sorter: Unified Sorter clean up stale temporary files (#1663) #1742

Merged
merged 14 commits into from
May 27, 2021
Merged

sorter: Unified Sorter clean up stale temporary files (#1663) #1742

merged 14 commits into from
May 27, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1663

What problem does this PR solve?

  • Unified Sorter is not able to clean up its temporary files if the process exits abnormally. If the process OOMs frequently, disk space can be exhausted and will require a manual clean-up.

What is changed and how it works?

  • File lock-based stale file detection and clean up.
  • Prevents multiple cdc server instances from sharing the same sort-dir.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has persistent data change

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to modify TiDB operator to make TiCDC a stateful set.

Release note

  • Add stale temporary files clean-up in Unified Sorter, and forbids sharing sort-dir.

@liuzix @ti-chi-bot
This is an automated cherry-pick of pingcap#1663
7f86548 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 8, 2021
Merged
@ti-chi-bot ti-chi-bot added component/puller Puller component. status/ptal Could you please take a look? size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. labels May 8, 2021
@ti-chi-bot ti-chi-bot requested a review from zier-one May 8, 2021 06:41
@overvenus
Copy link
Member

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 10, 2021
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 12, 2021
@amyangfei
Copy link
Contributor

/run-all-tests

@amyangfei
Copy link
Contributor

/run-kafka-tests

@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed status/ptal Could you please take a look? labels May 25, 2021
@lonng lonng added this to the v5.0.2 milestone May 25, 2021
@lonng
Copy link
Contributor

lonng commented May 25, 2021

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 7f86548

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 25, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 26, 2021
@amyangfei amyangfei added the release-blocker This issue blocks a release. Please solve it ASAP. label May 26, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 27, 2021
@liuzix
Copy link
Contributor

liuzix commented May 27, 2021

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 45c9178

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2021
@amyangfei
Copy link
Contributor

/run-unit-tests

@amyangfei
Copy link
Contributor

/run-leak-tests

@amyangfei
Copy link
Contributor

/run-kafka-tests

@amyangfei
Copy link
Contributor

/run-kafka-tests

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2021
@liuzix
Copy link
Contributor

liuzix commented May 27, 2021

/run-integration-tests

@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: a50b8c6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2021
@amyangfei
Copy link
Contributor

/run-unit-tests

@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-5.0@ff9a93c). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.0      #1742   +/-   ##
================================================
  Coverage               ?   54.0608%           
================================================
  Files                  ?        154           
  Lines                  ?      16265           
  Branches               ?          0           
================================================
  Hits                   ?       8793           
  Misses                 ?       6527           
  Partials               ?        945

@ti-chi-bot ti-chi-bot merged commit 5c008b3 into pingcap:release-5.0 May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@zier-one zier-one Awaiting requested review from zier-one

@liuzix liuzix Awaiting requested review from liuzix

Assignees

@liuzix liuzix

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/puller Puller component. release-blocker This issue blocks a release. Please solve it ASAP. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR.
Projects
None yet
Milestone
v5.0.2
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ti-chi-bot @overvenus @amyangfei @lonng @liuzix @codecov-commenter