Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic on unsigned tinyint #2649

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Fix panic on unsigned tinyint #2649

merged 1 commit into from
Aug 27, 2021

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Aug 26, 2021

What problem does this PR solve?

Closes #2648

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note 

Fix a bug that causes TiCDC to panic on an unsigned tinyint

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 26, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • liuzix

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 26, 2021
@CLAassistant
Copy link

CLAassistant commented Aug 26, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 26, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 27, 2021
@amyangfei amyangfei added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. labels Aug 27, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 27, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9054f34

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 27, 2021
@amyangfei
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

4 similar comments
@amyangfei
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

@amyangfei
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

@amyangfei
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

@amyangfei
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

@amyangfei
Copy link
Contributor

/run-kafka-tests

@ti-chi-bot ti-chi-bot merged commit 261eaac into pingcap:master Aug 27, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2654.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 27, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2655.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 27, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2656.

This was referenced Aug 27, 2021
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2657.

ti-chi-bot added a commit that referenced this pull request Aug 29, 2021
@ti-chi-bot
Fix panic on unsigned tinyint (#2649) (#2654)
b9e5a1f
ti-chi-bot added a commit that referenced this pull request Aug 29, 2021
@ti-chi-bot
Fix panic on unsigned tinyint (#2649) (#2657)
647cd36
ti-chi-bot added a commit that referenced this pull request Aug 30, 2021
@ti-chi-bot
Fix panic on unsigned tinyint (#2649) (#2656)
d7430c2
ti-chi-bot added a commit that referenced this pull request Aug 30, 2021
@ti-chi-bot
Fix panic on unsigned tinyint (#2649) (#2655)
ba28637
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@liuzix liuzix liuzix approved these changes

Assignees
No one assigned
Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CDC avro sink panic with unsigned tinyint
5 participants
@dveeden @ti-chi-bot @CLAassistant @amyangfei @liuzix