Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: add go gc metrics (#2977) #3000

Merged
merged 4 commits into from Oct 11, 2021
Merged

server: add go gc metrics (#2977) #3000

merged 4 commits into from Oct 11, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2977

What problem does this PR solve?

Add TiCDC go gc metric.

Before After
image image

Check List

  • Manual test (add detailed scripts or steps below)

Run TiCDC

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update key monitor metrics in both TiCDC document and official document

Release note 

None

@overvenus @ti-chi-bot
server: add go gc metrics
566d033 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus @ti-chi-bot
address lints
277dfa3 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus @ti-chi-bot
address comments
1282b01 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus @ti-chi-bot
address comments
66a2fd7 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. component/metrics-logging Metrics and logging component. do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR. labels Oct 9, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 9, 2021
Merged
@nongfushanquan nongfushanquan added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. labels Oct 11, 2021
@amyangfei amyangfei added this to the v5.2.2 milestone Oct 11, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 66a2fd7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 11, 2021
@ti-chi-bot ti-chi-bot merged commit 8e95c90 into pingcap:release-5.2 Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@overvenus overvenus

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/metrics-logging Metrics and logging component. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR.
Projects
None yet
Milestone
v5.2.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ti-chi-bot @amyangfei @overvenus @nongfushanquan