Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests, dm/tests: fix sync_diff configs for CI #3247

Merged
merged 44 commits into from
Nov 8, 2021
Merged

tests, dm/tests: fix sync_diff configs for CI #3247

merged 44 commits into from
Nov 8, 2021

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Nov 2, 2021 •
edited by lance6716

What problem does this PR solve?

sync_diff_spector's config has been updated.

close #3283

What is changed and how it works?

update sync_diff_spector's configs to v2.

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 2, 2021 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Ehco1996
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 2, 2021
@CLAassistant
Copy link

CLAassistant commented Nov 2, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 2, 2021
@lance6716
Copy link
Contributor

/run-dm-integration-tests

@glorv glorv added the area/dm Issues or PRs related to DM. label Nov 2, 2021
@Leavrth Leavrth changed the title dm/tests: fix sync_diff configs for CI tests, dm/tests: fix sync_diff configs for CI Nov 2, 2021
@Ehco1996
Copy link
Contributor

Ehco1996 commented Nov 3, 2021

/run-dm-integration-tests

@Ehco1996
Copy link
Contributor

Ehco1996 commented Nov 3, 2021

CI still faild 🈚🈚
failed to init Task: config changes breaking the checkpoint, please use another outputDir and start over again!

@Leavrth thanks for your work, but perhaps you could try running a it-test on your local machine to get quick feedback

you can use cmd like dm_integration_test CASE="openapi" to test if the new sync_diff config is right

run test need setup two mysql with different server id, see more here

@Ehco1996 Ehco1996 mentioned this pull request Nov 3, 2021
Merged
@Leavrth
Copy link
Contributor Author

Leavrth commented Nov 3, 2021

/run-dm-integration-tests

@Leavrth
Copy link
Contributor Author

Leavrth commented Nov 3, 2021

/run-dm-integration-tests

@Leavrth
Copy link
Contributor Author

Leavrth commented Nov 3, 2021

/run-dm-integration-tests

@Leavrth
Copy link
Contributor Author

Leavrth commented Nov 3, 2021

/run-dm-copy-test

1 similar comment
@Leavrth
Copy link
Contributor Author

Leavrth commented Nov 3, 2021

/run-dm-copy-test

@Leavrth
Copy link
Contributor Author

Leavrth commented Nov 8, 2021

/run-kafka-integration-test

2 similar comments
@Leavrth
Copy link
Contributor Author

Leavrth commented Nov 8, 2021

/run-kafka-integration-test

@Leavrth
Copy link
Contributor Author

Leavrth commented Nov 8, 2021

/run-kafka-integration-test

@ti-chi-bot ti-chi-bot merged commit 640da27 into pingcap:master Nov 8, 2021
@Ehco1996
Copy link
Contributor

Ehco1996 commented Nov 8, 2021

/merge

@Leavrth Leavrth added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. labels Nov 8, 2021
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 8, 2021
@Leavrth @ti-chi-bot
This is an automated cherry-pick of pingcap#3247
cb56c7a 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 8, 2021
@Leavrth @ti-chi-bot
This is an automated cherry-pick of pingcap#3247
044de74 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 8, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3322.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3323.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 8, 2021
@Leavrth @ti-chi-bot
This is an automated cherry-pick of pingcap#3247
fb7678f 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 8, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3324.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 8, 2021
@Leavrth @ti-chi-bot
This is an automated cherry-pick of pingcap#3247
30593a8 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Nov 8, 2021
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3325.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3326.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 8, 2021
Merged
@Leavrth Leavrth added the area/ticdc Issues or PRs related to TiCDC. label Nov 8, 2021
ti-chi-bot added a commit that referenced this pull request Nov 9, 2021
@ti-chi-bot
tests, dm/tests: fix sync_diff configs for CI (#3247) (#3325)
e65677a
ti-chi-bot added a commit that referenced this pull request Nov 10, 2021
@ti-chi-bot
tests, dm/tests: fix sync_diff configs for CI (#3247) (#3324)
f72b9d8
ti-chi-bot added a commit that referenced this pull request Nov 12, 2021
@ti-chi-bot
tests, dm/tests: fix sync_diff configs for CI (#3247) (#3323)
955db40
ti-chi-bot added a commit that referenced this pull request Nov 13, 2021
@ti-chi-bot
tests, dm/tests: fix sync_diff configs for CI (#3247) (#3322)
1f1369f
ti-chi-bot added a commit that referenced this pull request Nov 13, 2021
@ti-chi-bot
tests, dm/tests: fix sync_diff configs for CI (#3247) (#3326)
4fec618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@Ehco1996 Ehco1996 Ehco1996 approved these changes

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. area/ticdc Issues or PRs related to TiCDC. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DM Binlog 999999 keeps failing
8 participants
@Leavrth @ti-chi-bot @CLAassistant @lance6716 @Ehco1996 @codecov-commenter @hi-rustin @glorv