Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc/codec: fix string for unsigned value in canal-json. #4629

Merged

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Feb 18, 2022

What problem does this PR solve?

Issue Number: close #4635

What is changed and how it works?

handle the case when unsigned in string

Check List

Tests

  • No code

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

fix `Canal-JSON` meet `unsigned` SQL typed in `string`, which cause CDC server panic.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 18, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • maxshuang
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 18, 2022
@3AceShowHand 3AceShowHand added the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Feb 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2022

Codecov Report

Merging #4629 (4ff0b1f) into master (9607554) will decrease coverage by 0.1504%.
The diff coverage is 45.6942%.

Flag Coverage Δ
cdc 59.7319% <40.2969%> (-0.1903%) ⬇️
dm 51.8975% <52.3560%> (-0.1314%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4629        +/-   ##
================================================
- Coverage   55.6402%   55.4897%   -0.1505%     
================================================
  Files           494        508        +14     
  Lines         61283      63309      +2026     
================================================
+ Hits          34098      35130      +1032     
- Misses        23750      24686       +936     
- Partials       3435       3493        +58     

@3AceShowHand
Copy link
Contributor Author

/run-all-tests

cdc/sink/codec/canal.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 22, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 22, 2022
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4ff0b1f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 22, 2022
@ti-chi-bot
Copy link
Member

@3AceShowHand: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@3AceShowHand
Copy link
Contributor Author

/run-integration-test /tidb=pr/32434
/run-leak-test /tidb=pr/32434

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4657.

3AceShowHand added a commit to ti-chi-bot/tiflow that referenced this pull request Apr 11, 2022
3AceShowHand added a commit to 3AceShowHand/tiflow that referenced this pull request Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cdc mounter encode default value for unsigned into string, cause canal-json panic.
6 participants