Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter: using startts to filter txn #589

Merged
merged 1 commit into from
May 21, 2020

Conversation

zier-one
Copy link
Contributor

What problem does this PR solve?

using startts to filter txn

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Release note

@zier-one zier-one requested a review from overvenus May 21, 2020 08:20
@zier-one
Copy link
Contributor Author

/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

Merging #589 into master will increase coverage by 0.0183%.
The diff coverage is 45.0000%.

@@               Coverage Diff                @@
##             master       #589        +/-   ##
================================================
+ Coverage   33.7581%   33.7764%   +0.0183%     
================================================
  Files            71         71                
  Lines          7219       7221         +2     
================================================
+ Hits           2437       2439         +2     
  Misses         4604       4604                
  Partials        178        178                

Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one merged commit b66fffd into pingcap:master May 21, 2020
@zier-one zier-one deleted the startts_filter branch May 21, 2020 11:55
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants