Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ticdc): refine test case data col type #6285

Merged
merged 6 commits into from
Jul 15, 2022

Conversation

hi-rustin
Copy link
Member

What problem does this PR solve?

Issue Number: ref #5928

What is changed and how it works?

Correct col type and value in test.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note

None

@hi-rustin hi-rustin added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 15, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 15, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 15, 2022
@hi-rustin
Copy link
Member Author

/run-all-tests

@hi-rustin hi-rustin added component/test Unit tests and integration tests component. area/ticdc Issues or PRs related to TiCDC. labels Jul 15, 2022
@hi-rustin hi-rustin changed the title sink(ticdc): refine test case data col type test(ticdc): refine test case data col type Jul 15, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 15, 2022
@hi-rustin
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 15, 2022
@hi-rustin
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: adba2b7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 15, 2022
@hi-rustin
Copy link
Member Author

/run-verify

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2022

Codecov Report

Merging #6285 (41ca14b) into master (bcb773a) will increase coverage by 0.1169%.
The diff coverage is 73.6227%.

Flag Coverage Δ
cdc 66.0482% <72.1627%> (+0.1743%) ⬆️
dm 51.9443% <77.0491%> (+0.0714%) ⬆️
engine 63.1687% <100.0000%> (+0.0719%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #6285        +/-   ##
================================================
+ Coverage   59.0443%   59.1612%   +0.1169%     
================================================
  Files           736        738         +2     
  Lines         85346      85414        +68     
================================================
+ Hits          50392      50532       +140     
+ Misses        30483      30425        -58     
+ Partials       4471       4457        -14     

@ti-chi-bot ti-chi-bot merged commit a28d1b1 into pingcap:master Jul 15, 2022
@hi-rustin hi-rustin deleted the rustin-patch-sink-test-refine branch August 15, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. component/test Unit tests and integration tests component. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants