Feature/sink canal protocol #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update fork
|
|
zier-one
added
component/sink
To pass the ci check
|
/run-integration-tests |
zier-one
reviewed
Jun 15, 2020
Codecov Report
@@ Coverage Diff @@
## master #649 +/- ##
================================================
+ Coverage 32.4923% 33.0177% +0.5254%
================================================
Files 84 87 +3
Lines 8482 8768 +286
================================================
+ Hits 2756 2895 +139
- Misses 5512 5646 +134
- Partials 214 227 +13 |
amyangfei
reviewed
Jun 15, 2020
overvenus
reviewed
Jun 15, 2020
| @@ -0,0 +1,154 @@ | |||
| syntax = "proto3"; | |||
There was a problem hiding this comment.
Could you add Alibaba Apache-2.0 license header?
| @@ -0,0 +1,230 @@ | |||
| syntax = "proto3"; | |||
There was a problem hiding this comment.
Could you add Alibaba Apache-2.0 license header?
add warning log for unsupported EventBatchEncoder protocol reorder the imports in cdc/sink/codec/interface.go
|
/run-integration-tests |
|
/run-integration-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
support canal protocol in mqSink
#607
What is changed and how it works?
implements the EventBatchEncoder interface by CanalEventBatchEncoder
Tests
Release note