cdc, pkg: replace table ID with table name in metrics #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
/run-integration-tests |
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## master #695 +/- ##
===========================================
Coverage 32.2594% 32.2594%
===========================================
Files 90 90
Lines 9653 9653
===========================================
Hits 3114 3114
Misses 6285 6285
Partials 254 254 |
amyangfei
reviewed
Jun 28, 2020
cdc/processor.go
Outdated
| @@ -163,7 +163,7 @@ func newProcessor( | |||
| // so we set `needEncode` to false. | |||
| log.Info("start processor with startts", zap.Uint64("startts", checkpointTs)) | |||
| ddlPuller := puller.NewPuller(pdCli, kvStorage, checkpointTs, []regionspan.Span{regionspan.GetDDLSpan(), regionspan.GetAddIndexDDLSpan()}, false, limitter) | |||
| ctx = util.PutTableIDInCtx(ctx, 0) | |||
| ctx = util.PutTableInfoInCtx(ctx, 0, "") | |||
There was a problem hiding this comment.
This line can be removed now
cdc/processor.go
Outdated
| @@ -214,7 +214,7 @@ func newProcessor( | |||
| func (p *processor) Run(ctx context.Context) { | |||
| wg, cctx := errgroup.WithContext(ctx) | |||
| p.wg = wg | |||
| ddlPullerCtx, ddlPullerCancel := context.WithCancel(util.PutTableIDInCtx(cctx, 0)) | |||
| ddlPullerCtx, ddlPullerCancel := context.WithCancel(util.PutTableInfoInCtx(cctx, 0, "")) | |||
There was a problem hiding this comment.
what about assigning a mock table name, such as ticdc-processor-ddl, ditto for the context used in the onwer's ddl puller.
| for tableID, op := range operation { | ||
| var orphanMarkTableID model.TableID | ||
| tableName, found := schemaSnapshot.GetTableNameByID(tableID) | ||
| if !found { | ||
| continue |
There was a problem hiding this comment.
Better to add a warning log here
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
/run-integration-tests |
1 similar comment
|
/run-integration-tests |
|
/run-integration-tests |
|
Base on prometheus spec, label name must match the regex |
5kbpers
pushed a commit
to 5kbpers/ticdc
that referenced
this pull request
Aug 24, 2020
* cdc, pkg: replace table ID with table name in metrics * cherry-pick pingcap#692 bugfix Signed-off-by: Neil Shen <overvenus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Replace table ID with table name in metrics.
Cc #677
Check List
Tests
Code changes
Side effects
Related changes
Release note