sinkmanager(ticdc): add table sink wrapper #7453
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
hi-rustin
force-pushed
the
rustin-patch-sinkmanager-table-sink
branch
from
9c50004
to
8e67f4a
Compare
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #7453 +/- ##
================================================
+ Coverage 59.8150% 59.8735% +0.0585%
================================================
Files 803 804 +1
Lines 92129 92398 +269
================================================
+ Hits 55107 55322 +215
- Misses 32213 32267 +54
Partials 4809 4809 |
ti-chi-bot
added
size/XXL
hi-rustin
added
component/sink
Added. Thanks for your reminder. |
|
|
||
| // convertRowChangedEvents uses to convert RowChangedEvents to TableSinkRowChangedEvents. | ||
| // It will deal with the old value compatibility. | ||
| func convertRowChangedEvents(changefeed model.ChangeFeedID, tableID model.TableID, enableOldValue bool, events ...*model.PolymorphicEvent) ([]*model.RowChangedEvent, error) { |
There was a problem hiding this comment.
is it reasonable to put this method in this struct?
There was a problem hiding this comment.
No, it will also be used to redo tasks. It is more like a util.
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: bd44299
|
ti-chi-bot
added
the
status/can-merge
|
@hi-rustin: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: ref #5928
What is changed and how it works?
This PR introduces the table sink wrapper, and it is used to emit data to the table sink. It is difficult to reuse the sink node so we have to add a new wrapper.
And we introduce a progress heap to track the fetch progress. It is a thread-safe heap.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note